Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mobilebuildmcp device buildfails withdeviceId requires buildForTesting to be truewhen a phone is saved in session defaults. The CLI promotes the saveddeviceIdinto an explicit argument before invoking the shared handler, bypassing the handler's filtering of saved installation destinations. This regression was introduced by the prepared-test support in #475.Exclude the saved
deviceIdfrom CLI defaults forbuild_device. Explicit--device-idand--jsonarguments still reach the existing validation, and build-and-run, install, and test commands retain their configured destination. Add nine CLI regression cases covering normal and prepared builds, named profiles, explicit destinations, and the other device commands.Validation:
npm run lint:fix,npm run typecheck,npm run format,npm run buildnpm test: 2,600 unit tests and 16 watchdog checks passed.npx prettier --check CHANGELOG.mddevice buildagainst an existing iOS project with a saved phone ID.The manual runtime-boundary checklist was reviewed. The Warden CLI was unavailable locally (
warden: command not found).