fix: Support Windows#141
Open
ofek wants to merge 1 commit into
Open
Conversation
|
@ofek is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Jul 21, 2026
### What does this PR do? This moves over the MCP config we currently define in our dev env [here](https://github.com/DataDog/datadog-agent-buildimages/blob/main/dev-envs/linux/claude.sh) and [here](https://github.com/DataDog/datadog-agent-buildimages/blob/main/dev-envs/linux/codex.sh). ### Motivation We want to remove all dependence on tools and config defined externally. For this change in particular, it's also far easier to configure and more compatible with the AI agent ecosystem. ### Additional Notes I chose to use [dotagents](https://github.com/getsentry/dotagents) rather than writing our own tooling, for now, as it supports most of what we want and running JavaScript apps is pretty easy since mise is already [available](https://github.com/DataDog/datadog-agent-buildimages/blob/main/tools/dotslash/config/mise.json) in our dev envs. I opened a [PR](getsentry/dotagents#141) that adds support for Windows. Co-authored-by: ofek.lev <ofek.lev@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
HOME, but on Windows the home directory comes fromUSERPROFILE, so the sandbox did nothing and the test ran against the developer's real configuration, moving their installed skills into a temp directory and deleting them on teardown. It now sandboxes both and asserts the sandbox took effect, so a future gap fails the test instead of the machine. It was honestly a grueling experience to reconstruct all of the custom skills stored in~\.claude\skillsthat I was working on for the past year and I was only able to recover about half.path:andgit:skill sources unusable on Windows.C:\repoandD:\repostay distinct.agents.tomleven after it had resolved. It now accepts both.Other changes
//server/sharelooks absolute but names a remote host over SMB, which is what the domain allowlist exists for. This applies to POSIX too, where an absolute local git source was rejected the same way.Verification