Skip to content

fix(dashboard): keep task source tooltips short and wider #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 1 commit into from
Aug 25, 2026
+9 −15
Merged

fix(dashboard): keep task source tooltips short and wider #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/junior-dashboard/src/client/components/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export function Tooltip({
className={cn(
"z-50 select-text outline-none",
className ??
"min-w-36 max-w-64 rounded-md border border-dashboard-border-emphasis bg-dashboard-surface-raised px-3 py-2 font-mono text-xs leading-relaxed text-dashboard-text-muted shadow-2xl shadow-black/70",
"min-w-36 max-w-lg rounded-md border border-dashboard-border-emphasis bg-dashboard-surface-raised px-3 py-2 font-mono text-xs leading-relaxed text-dashboard-text-muted shadow-2xl shadow-black/70",
)}
collisionPadding={VIEWPORT_GAP}
hideWhenDetached
Expand Down
19 changes: 5 additions & 14 deletions packages/junior-dashboard/src/client/conversations/ConversationMeta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,6 @@ function SourceTask(props: {
}) {
const kindLabel =
props.sourceTask.kind === "scheduled" ? "Scheduled Task" : "Event Task";
const label = props.sourceTask.label?.trim();
const taskId = props.sourceTask.id?.trim();
const title = props.sourceTask.title?.trim();
const link = taskId ? (
Expand All @@ -558,24 +557,16 @@ function SourceTask(props: {
) : (
<span>Triggered by {kindLabel}</span>
);
if (!label && !title) return link;
// Keep tooltips to short identity fields. Full task prompts belong on the
// task details page, not in hover chrome.
if (!title) return link;
return (
<Tooltip
align="left"
content={
<span className="grid grid-cols-[auto_minmax(0,1fr)] gap-x-3 gap-y-1">
{title ? (
<>
<span>Title</span>
<span className="text-dashboard-text">{title}</span>
</>
) : null}
{label ? (
<>
<span>Instruction</span>
<span className="text-dashboard-text">{label}</span>
</>
) : null}
<span>Title</span>
<span className="text-dashboard-text">{title}</span>
{taskId ? (
<>
<span>ID</span>
Expand Down
3 changes: 3 additions & 0 deletions packages/junior-dashboard/tests/telemetry-components.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,6 +1879,9 @@ describe("dashboard canonical-event components", () => {
expect(html).toMatch(
/href="\/tasks\/sched_source_task"[^>]*>Triggered by Scheduled Task<\/a>/,
);
// Full task prompts stay off hover chrome; open the task page for those.
expect(html).not.toContain("Update getsentry/yc-scraper");
expect(html).not.toContain("Instruction");
expect(html).not.toContain(
"Triggered by Scheduled Task · Update getsentry/yc-scraper",
);
Expand Down
Loading