ref(dashboard): split large app and route tests - #1681
Merged
Conversation
Move shell rendering out of the dashboard app entry and split the route tests so both stay under the file length limit. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
August 25, 2026 03:40
Dashboard visual evidenceMode: path-selected Triggered by:
Component gallery index · desktop
Full-page screenshots from the mock dashboard. Not a pixel-diff gate. |
dcramer
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main fails the file length check because the dashboard app file and its route tests went over 1,000 lines.
This moves shell page and asset rendering into
shell.ts, and splits the route tests into shell and auth setup suites. Behavior stays the same. The goal is to clear the length check with real splits, not exceptions or line-shaving.Requested by David Cramer.
--
View Junior Session [Sentry]