ref(project-state): Introduce a dedicated state for 'new allowed'#5998
Open
Dav1dde wants to merge 2 commits into
Open
ref(project-state): Introduce a dedicated state for 'new allowed'#5998Dav1dde wants to merge 2 commits into
Dav1dde wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a dedicated state in the
ProjectStatefor Proxy Relays which do not fetch project configs from upstream.This makes a few implicit decisions explicit and more obvious. This PR is largely without side-effects. The biggest "hidden" change is that
enabled()now returnsNonefor the new state, but all usages ofenabled()use it to check feature flags, which will always fail even with the previous dummy state.Also taking suggestions for a better name than
DummyAllowed.