Skip to content

fix: preserve falsy scalar JSON primitives in json_params_matcher (#834) #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayureshsonawane17 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −1
Open

fix: preserve falsy scalar JSON primitives in json_params_matcher (#834) #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion responses/matchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def json_params_matcher(
def match(request: PreparedRequest) -> Tuple[bool, str]:
reason = ""
request_body = request.body
json_params = (params or {}) if not isinstance(params, list) else params
json_params = {} if params is None else params
try:
if isinstance(request.body, bytes):
try:
Expand Down
17 changes: 17 additions & 0 deletions responses/tests/test_matchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,23 @@ def test_json_params_matcher_body_is_gzipped():
assert result == (True, "")


@pytest.mark.parametrize(
("param", "body_str"),
[
(0, "0"),
(False, "false"),
("", '""'),
(0.0, "0.0"),
(True, "true"),
("hello", '"hello"'),
],
)
def test_json_params_matcher_primitives(param, body_str):
mock_request = Mock(body=body_str)
result = matchers.json_params_matcher(param)(mock_request)
assert result == (True, "")


def test_urlencoded_params_matcher_blank():
@responses.activate
def run():
Expand Down