Skip to content

fix(mapping): Report a single frame when no line number and no signature are present - #95

Merged
markushi merged 2 commits into
masterfrom
markushi/fix/inline-expansion-without-line-numbers
Jul 28, 2026
Merged

fix(mapping): Report a single frame when no line number and no signature are present#95
markushi merged 2 commits into
masterfrom
markushi/fix/inline-expansion-without-line-numbers

Conversation

@markushi

@markushi markushi commented Jul 27, 2026

Copy link
Copy Markdown
Member

Tombstone stacktraces have no line numbers and no signatures — a frame is
just a.b.c. When every mapping entry for the method is keyed by a
minified line range, nothing can select one, and we emitted every entry
whenever their original names differed. Since R8 reuses one obfuscated name
for many unrelated bodies, a single frame can quickly expand into hundreds
of unrelated frames.

This PR mimics retracer's behavior by reporting only the first range group's
outermost entry. Inlinees are dropped, because we don't have enough information.

Verified frame-for-frame against retrace 8.9.27 on inline chains (2- and
3-deep), a chain followed by distinct ranges, real overloads, and against the original issue report.

Also changes behavior beyond the reported bug: test_inline_group_no_base_entries
and its cache twin asserted a 3-frame expansion for a line-less frame and now
assert the single outermost frame, confirmed against retrace.

Fixes JAVA-646

@markushi
markushi requested review from a team and romtsn as code owners July 27, 2026 11:52
@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

JAVA-646

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f23e6ea. Configure here.

Comment thread src/mapper.rs Outdated
Comment thread tests/r8-inline.rs Outdated
Comment thread src/mapper.rs Outdated
…nline chain

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@markushi
markushi requested a review from loewenheim July 28, 2026 07:53
@markushi
markushi merged commit 521f712 into master Jul 28, 2026
14 checks passed
@markushi
markushi deleted the markushi/fix/inline-expansion-without-line-numbers branch July 28, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants