test(flutter): Fix OnProcessSpan calls missing Hint argument - #3858
test(flutter): Fix OnProcessSpan calls missing Hint argument#3858buenaflor wants to merge 1 commit into
Conversation
PR #3847 added a required hint parameter to OnProcessSpan but missed the five call sites in thread_info_integration_test.dart, which landed in parallel. This breaks compilation of the flutter test suite and the analyze gate on v10-branch, failing CI for every PR based on it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Flutter integration test thread_info_integration_test.dart to match the updated OnProcessSpan lifecycle event constructor signature (now requiring a Hint), restoring compilation on the v10-branch CI (analyze + Flutter web JS jobs).
Changes:
- Update five
OnProcessSpan(span)call sites toOnProcessSpan(span, Hint())inthread_info_integration_test.dart.
Standards
- Findings: 0 (worst issue: none)
Spec
- Findings: 0 (worst issue: none)
Correctness
- Findings: 0 (worst issue: none)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v10-branch #3858 +/- ##
=============================================
Coverage ? 91.67%
=============================================
Files ? 105
Lines ? 3855
Branches ? 0
=============================================
Hits ? 3534
Misses ? 321
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Fixes compilation of
thread_info_integration_test.dartonv10-branch, which currently breaks theanalyzeand flutterjsCI jobs for every PR targeting the branch.#3847 added a required
hintparameter toOnProcessSpanand updated its call sites, but this test file landed in parallel and still constructs the event with one argument. The five call sites now passHint(), matching the pattern inload_contexts_integration_test.dartandreplay_telemetry_integration_test.dart.🤖 Generated with Claude Code