Skip to content

test(flutter): Fix OnProcessSpan calls missing Hint argument - #3858

Closed
buenaflor wants to merge 1 commit into
v10-branchfrom
fix/thread-info-onprocessspan-hint
Closed

test(flutter): Fix OnProcessSpan calls missing Hint argument#3858
buenaflor wants to merge 1 commit into
v10-branchfrom
fix/thread-info-onprocessspan-hint

Conversation

@buenaflor

@buenaflor buenaflor commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fixes compilation of thread_info_integration_test.dart on v10-branch, which currently breaks the analyze and flutter js CI jobs for every PR targeting the branch.

#3847 added a required hint parameter to OnProcessSpan and updated its call sites, but this test file landed in parallel and still constructs the event with one argument. The five call sites now pass Hint(), matching the pattern in load_contexts_integration_test.dart and replay_telemetry_integration_test.dart.

🤖 Generated with Claude Code

PR #3847 added a required hint parameter to OnProcessSpan but missed
the five call sites in thread_info_integration_test.dart, which landed
in parallel. This breaks compilation of the flutter test suite and the
analyze gate on v10-branch, failing CI for every PR based on it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 6, 2026 11:35
@buenaflor
buenaflor requested a review from denrase as a code owner July 6, 2026 11:35
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Flutter integration test thread_info_integration_test.dart to match the updated OnProcessSpan lifecycle event constructor signature (now requiring a Hint), restoring compilation on the v10-branch CI (analyze + Flutter web JS jobs).

Changes:

  • Update five OnProcessSpan(span) call sites to OnProcessSpan(span, Hint()) in thread_info_integration_test.dart.

Standards

  • Findings: 0 (worst issue: none)

Spec

  • Findings: 0 (worst issue: none)

Correctness

  • Findings: 0 (worst issue: none)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@buenaflor

Copy link
Copy Markdown
Contributor Author

Superseded — the fix was applied directly on #3845 (commit 81d0b07), which targets v10-branch and will carry it in.

@buenaflor buenaflor closed this Jul 6, 2026
@buenaflor
buenaflor deleted the fix/thread-info-onprocessspan-hint branch July 6, 2026 11:43
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v10-branch@48a1579). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##             v10-branch    #3858   +/-   ##
=============================================
  Coverage              ?   91.67%           
=============================================
  Files                 ?      105           
  Lines                 ?     3855           
  Branches              ?        0           
=============================================
  Hits                  ?     3534           
  Misses                ?      321           
  Partials              ?        0           
Flag Coverage Δ
sentry_firebase_remote_config 100.00% <ø> (?)
sentry_flutter 91.28% <ø> (?)
sentry_supabase 97.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants