docs(product): Update screenshots on Ownership Rules page - #18882
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84b5144. Configure here.
|  | ||
|
|
||
| When you create a rule from the **Issue Details** page, you'll see some suggested paths and URLs based on the events in the issue. Note that [sentry.io](https://sentry.io) doesn't suggest tags. | ||
| When you create a rule from an **Issue Details** page, you'll see some suggested paths and URLs based on the events in the issue. Note that [sentry.io](https://sentry.io) doesn't suggest tags. |
There was a problem hiding this comment.
Orphaned ownership rules screenshot
Low Severity
The reference to issue_details_edit_ownership_rules.png was removed, but the image file still remains under img/. Other removed screenshots appear to have been deleted, so this leftover asset looks unused and adds avoidable clutter.
Reviewed by Cursor Bugbot for commit 84b5144. Configure here.
- Fix factual error: CODEOWNERS exclusion rules are now supported - Fix UI references: assignee selector is now in header, not sidebar cog - Fix auto-assignment: document all 3 options (suspect commits, issue owner, off) - Improve page structure with clearer hierarchy and table for rule types - Add rule syntax examples with code block - Add dedicated Permissions section - Streamline Code Owners section with setup steps - Expand troubleshooting with common issues (rules not matching, auto-assignment not working, code owners not matching)
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| path:backend/endpoints/auth/* #auth-team #enterprise-team | ||
| ``` | ||
|
|
||
| For this event, we: | ||
|
|
||
| 1. Evaluate against the code owners top-to-bottom; we get three matches. | ||
| 2. Evaluate against the ownership rules top-to-bottom; we get two matches. | ||
|
|
||
| The matches, in order, are: | ||
| Sentry evaluates the code owners top-to-bottom first, then ownership rules top-to-bottom. The matches, in order, are: | ||
|
|
||
| ``` | ||
| [ |
There was a problem hiding this comment.
Bug: The documentation incorrectly states that Sentry supports CODEOWNERS exclusion rules. The product actually ignores these rules, leading to silent failures in ownership assignment.
Severity: MEDIUM
Suggested Fix
Revert the documentation change to reflect the actual product behavior. The documentation should state that Sentry does not support exclusion rules (lines without owners) in CODEOWNERS files and that such lines are ignored.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/product/issues/ownership-rules/index.mdx#L140-L146
Potential issue: The documentation is being updated to claim that Sentry supports GitHub
`CODEOWNERS` file syntax, including exclusion rules (lines without owners). However,
evidence indicates that Sentry does not support this feature and silently ignores lines
in `CODEOWNERS` files that do not have an owner. Users who rely on this updated
documentation will find that their exclusion rules do not work as expected, leading to
incorrect issue ownership assignment without any warning or error.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Stale content. This behavior was updated in May.
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
Added a few more updates to the latest content related to ownership rules and refactored the page.
2 participants
DESCRIBE YOUR PR
the page: /product/issues/ownership-rules/
I think this page needs some love (update content, structure, writing) @sfanahata
Closes: #18214
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES