ci: repoint watch-upstream to relocated AssemblyStore reader - #5453
Open
jamescrosswell wants to merge 2 commits into
Open
ci: repoint watch-upstream to relocated AssemblyStore reader#5453jamescrosswell wants to merge 2 commits into
jamescrosswell wants to merge 2 commits into
Conversation
dotnet/android#12108 (commit f1aecf9) deleted tools/assembly-store-reader-mk2/ and moved the AssemblyStore parser we vendor in src/Sentry.Android.AssemblyReader/ to .github/skills/read-assembly-store/src/AssemblyStore/. Our watch matrix still tracked the old path, which will never receive another commit, so we would silently stop being alerted to upstream changes. Point the watcher at the new location. #skip-changelog Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 512 512
Lines 18722 18722
Branches 3660 3660
=======================================
Hits 13983 13983
Misses 3866 3866
Partials 873 873 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
commented
Jul 28, 2026
jamescrosswell
marked this pull request as ready for review
July 28, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet/android#12108 (commit
f1aecf9) deletedtools/assembly-store-reader-mk2/and moved the AssemblyStore parser we vendor into.github/skills/read-assembly-store/src/AssemblyStore/.Our
watch-upstreammatrix still tracked the old path. That path will never receive another commit, so the watcher would silently stop alerting us to upstream changes. This repoints it at the new location (and freshens the matrixname).Surfaced by the watcher itself in #5451.
Follow-ups (next major, not in this PR)
The move rides on a stack (#12104 / #12108) that also introduced upstream logic we don't yet vendor:
_assembly_storeELF symbol payload lookup, and variable index-entry sizing — tracked in Port upstream AssemblyStore reader changes: v4/CoreCLR format, _assembly_store symbol, index-entry sizing (next major) #5454.Issues
Closes #5451
#skip-changelog