fix(serilog): logs from application namespaces beginning with "Sentry" are discarded - #5456
Open
jamescrosswell wants to merge 2 commits into
Open
fix(serilog): logs from application namespaces beginning with "Sentry" are discarded#5456jamescrosswell wants to merge 2 commits into
jamescrosswell wants to merge 2 commits into
Conversation
…ing with "Sentry" The Serilog sink dropped any log event whose SourceContext started with "Sentry.", a heuristic meant to keep the SDK's own diagnostics from looping back into Sentry. It also matched application code, so an app logging under e.g. "Sentry.Samples.AspNetCore.Serilog.Program" had its events silently discarded - no event, no breadcrumb, no structured log, and no event processors run. Our own ASP.NET Core Serilog sample is written in exactly that namespace. The filter is still needed: MelDiagnosticLogger routes SDK diagnostics through ILogger<ISentryClient> when Debug is enabled, which Serilog would otherwise feed straight back in. So instead of matching a bare prefix, match the namespace roots the SDK actually owns. Those are generated at build time from the package list in .craft.yml, so the list can't go stale as packages are added. The core "Sentry" package can't be a prefix root - all its types live under "Sentry.", as does user code - so it is matched exactly, along with the one category core ever logs under. Sentry.Extensions.Logging shared the same heuristic, including a #if DEBUG carve-out for "Sentry.Samples." that only ever helped samples built from source. Both integrations now use the same helper. Also adds the missing Sentry.Maui.CommunityToolkit.Mvvm entry to .craft.yml. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5456 +/- ##
=======================================
Coverage 74.69% 74.70%
=======================================
Files 512 513 +1
Lines 18722 18729 +7
Branches 3660 3663 +3
=======================================
+ Hits 13985 13992 +7
Misses 3865 3865
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
commented
Jul 29, 2026
jamescrosswell
commented
Jul 29, 2026
jamescrosswell
commented
Jul 29, 2026
jamescrosswell
commented
Jul 29, 2026
jamescrosswell
commented
Jul 29, 2026
jamescrosswell
marked this pull request as ready for review
July 30, 2026 04:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5265
Summary
SentrySinkdiscarded any Serilog event whoseSourceContextstarted with"Sentry.". That heuristic dates back to 2019 ("don't log self log") and is meant to stop the SDK's own diagnostics looping back into Sentry — but it also matches application code. An app logging under, say,Sentry.Samples.AspNetCore.Serilog.Programhad its log events dropped before anything was created: no event, no breadcrumb, no structured log, and therefore no event processors run. That last symptom is how #5265 was reported, butISentryEventProcessorwas never the problem.Our own
samples/Sentry.Samples.AspNetCore.Seriloguses that namespace, so the sample demonstrating theILoggerpath was silently broken — which is where the reporter picked it up.The filter can't simply be removed.
MelDiagnosticLoggerroutes SDK diagnostics throughILogger<ISentryClient>wheneverDebugis enabled (ApplicationBuilderExtensions.cs), and with Serilog as the MEL backend that's a genuine feedback loop. TheisReentrantguard in the sink doesn't cover it, because the transport logs from the background worker thread.So the check now matches the namespace roots the SDK actually owns, rather than a bare
"Sentry."prefix.Notes for review
GenerateSentrySdkNamespacestarget inSentry.csprojreads the package list out of.craft.ymlat build time and emitsSentrySdkNamespaces.g.cs. No reflection (AOT/trimming-safe) and no list to keep in sync as packages are added..craft.yml's line order is fixed, so output is deterministic. The target hard-errors rather than emitting an empty list, since an empty list would silently restore the loop risk.Sentrypackage can't be a prefix root. All of its types live underSentry.— and so does user code — so treating it as a prefix would reproduce the original bug. Core has no logging dependency of its own, and the only category it ever logs under isSentry.ISentryClient(fromMelDiagnosticLogger), so that plus a bareSentryare matched exactly. This is the one hardcoded string in the change; it's commented next to the thing that produces it.Sentry.Extensions.Loggingis included deliberately.SentryLogger.IsFromSentry()carried the same heuristic plus a#if DEBUGcarve-out forSentry.Samples., which only ever helped samples built from source — anyone on the released package was still affected. Both integrations now share one helper.Sentry.NLogandSentry.Log4Nethave never had this filter at all; that asymmetry is left as-is here..craft.ymlgainsSentry.Maui.CommunityToolkit.Mvvm, which is packable but was missing from the registry list. Worth a second pair of eyes: it's a release-config change riding along with a bug fix, and it means the release registry starts tracking that package... main reason for including it in this PR is that we're usingcraft.ymlto generate the list of namespaces that we match against for log filtering.