fix: Add missing main process context to data from other processes - #1445
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 457b27b. Configure here.
… profile chunk paths
timfish
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 1, 2026
…24896) The continuous profiler sent `profile_chunk` envelopes straight to the transport, so the `beforeEnvelope` hook never ran for them. It now uses `client.sendEnvelope()`, as the browser `UIProfiler` does. - Ref. getsentry/sentry-electron#1445
JPeer264
approved these changes
Oct 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some data from renderer and utility processes is forwarded to Sentry without passing through the main process client. It was missing context that events from those processes already get.
Renderer spans now get:
sentry.releaseandsentry.environmentfrom the main process (environment was alwaysproduction)sentry.sdk.nameandsentry.sdk.versionfor the Electron SDKelectron.processos.*anddevice.*on segment spansingest_settings.infer_ipfrom the main processdataCollection.userInfourl.fullandurl.pathnormalized relative to the app pathUtility process spans, logs and metrics now get the same release, environment, SDK,
electron.process, OS and device attributes. Their envelope headers use the Electron SDK and the main process trace context.Main process spans now get
electron.process: browser, the same as logs. ThebeforeEnvelopehook now normalizes frame paths in profile chunks. Chunks from@sentry/profiling-nodeonly reach that hook once getsentry/sentry-javascript#24896 is released, so the test assertion for them is disabled until then.