feat(solid): Set url attributes on solid router and tanstack router spans - #22156
Closed
Lms24 wants to merge 1 commit into
Closed
feat(solid): Set url attributes on solid router and tanstack router spans#22156Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
…pans Adds url.template, url.path, and url.full to pageload and navigation spans for Solid Router and TanStack Solid Router, including redirect and back-button navigation cases. Updates solidstart and solid-tanstack-router e2e tests. part of #21921 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24
requested review from
chargome,
mydea and
nicohrubec
and removed request for
a team
July 9, 2026 16:44
Member
Author
|
hold on, this is just slop at the moment. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
url.template,url.path, andurl.fullto pageload and navigation spans for Solid Router and TanStack Solid Router, including redirect and back-button navigation cases.Updates the solidstart and solid-tanstack-router e2e tests and adds unit tests for the TanStack Solid Router integration.
part of #21921
Made with Cursor