feat(deno): add tedious integration - #22451
Merged
isaacs merged 1 commit intoJul 24, 2026
Merged
Conversation
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 21, 2026 17:45
0ec660a to
e5c344f
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
2 times, most recently
from
July 21, 2026 18:04
f60042f to
2c56d4d
Compare
isaacs
marked this pull request as ready for review
July 21, 2026 18:05
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 18:05
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 21, 2026 18:20
2c56d4d to
25fba03
Compare
isaacs
requested review from
chargome,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
July 21, 2026 18:20
logaretm
approved these changes
Jul 21, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 21, 2026 19:36
25fba03 to
f1886be
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 21, 2026 19:49
f1886be to
12e9157
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 21, 2026 21:43
12e9157 to
a0c07d1
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 22, 2026 00:51
a0c07d1 to
efce2ee
Compare
nicohrubec
approved these changes
Jul 22, 2026
JPeer264
approved these changes
Jul 22, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Actually exciting not tedious 🥳
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 22, 2026 14:42
efce2ee to
cb45771
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 22, 2026 22:02
cb45771 to
9cd5508
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 14:29
9cd5508 to
022db22
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 18:10
022db22 to
4fc8165
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 20:46
4fc8165 to
99b4efc
Compare
Comment on lines
+58
to
+62
| Deno.test('tedious instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('Tedious'), `Tedious should be in defaults, got ${names.join(', ')}`); |
Contributor
There was a problem hiding this comment.
Bug: The Tedious integration test will fail on Deno < 2.8.0 because it lacks a conditional ignore flag, while the integration itself is version-dependent.
Severity: MEDIUM
Suggested Fix
Add a conditional ignore property to the Deno.test object, making it dependent on the MODULE_REGISTER_HOOKS_SUPPORTED constant. This will ensure the test is skipped on Deno versions where the feature is not supported, aligning it with the pattern used in other version-gated tests like in deno-http.test.ts.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: dev-packages/deno-integration-tests/suites/orchestrion-tedious/test.ts#L58-L62
Potential issue: The test 'tedious instrumentation: included in default integrations
(Deno 2.8.0+)' unconditionally asserts that the 'Tedious' integration is present.
However, the integration itself is only added if the `MODULE_REGISTER_HOOKS_SUPPORTED`
flag is true, which corresponds to Deno versions 2.8.0 and newer. The test lacks a
conditional `ignore` property to prevent it from running on older Deno versions. As a
result, any CI or test environment running on Deno < 2.8.0 will experience a test
failure because the assertion will fail when the integration is not found.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 21:19
99b4efc to
9f68974
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 22:45
9f68974 to
da8bc8f
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-tedious
branch
from
July 23, 2026 22:47
da8bc8f to
04939c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.