feat(deno): add hapi integration - #22462
Merged
Merged
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 19:40
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 21, 2026 19:49
6b79404 to
519f13a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 21, 2026 21:43
519f13a to
4298281
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 22, 2026 00:51
4298281 to
37ffb67
Compare
nicohrubec
approved these changes
Jul 22, 2026
JPeer264
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 22, 2026 14:42
37ffb67 to
0460096
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
andreiborza
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
2 times, most recently
from
July 23, 2026 14:29
8767f9b to
d3446ae
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 23, 2026 18:10
d3446ae to
8af9b45
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
2 times, most recently
from
July 23, 2026 21:19
1499dd4 to
1500427
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
2 times, most recently
from
July 23, 2026 22:47
3428b52 to
f18c9dd
Compare
Base automatically changed from
isaacs/deno-orchestrion-integrations-express
to
develop
July 24, 2026 01:22
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 24, 2026 01:25
f18c9dd to
ff453d1
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 24, 2026 14:31
ff453d1 to
1cece51
Compare
Comment on lines
+57
to
+62
| Deno.test('hapi instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('Hapi'), `Hapi should be in defaults, got ${names.join(', ')}`); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The Hapi integration test will fail when run on Deno versions older than 2.8.0 because it doesn't conditionally check for the integration's presence.
Severity: LOW
Suggested Fix
Conditionally skip the test on Deno versions less than 2.8.0. This can be achieved by using the ignore property in Deno.test based on a version check, similar to how the integration itself is conditionally included.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: dev-packages/deno-integration-tests/suites/orchestrion-hapi/test.ts#L57-L62
Potential issue: The test for Hapi instrumentation in `orchestrion-hapi/test.ts` asserts
that the `Hapi` integration is included in the default integrations. However, the
integration is only added when the `MODULE_REGISTER_HOOKS_SUPPORTED` flag is true, which
requires Deno version 2.8.0 or greater. The test itself is not conditionally executed
based on the Deno version. Consequently, if the test suite is run on a Deno version
older than 2.8.0, the test will fail because it incorrectly expects the `Hapi`
integration to be present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.