Skip to content

feat(cloudflare): Prepare for nodejs_compat entrypoint - #22891

Open
JPeer264 wants to merge 1 commit into
developfrom
jp/prepare-nodejs-compat
Open

feat(cloudflare): Prepare for nodejs_compat entrypoint#22891
JPeer264 wants to merge 1 commit into
developfrom
jp/prepare-nodejs-compat

Conversation

@JPeer264

Copy link
Copy Markdown
Member

This changes nodejs_als to nodejs_compat in the tests, as the next PRs do require that in order to import from it. In theory nodejs_als would still work when building and then running the final result because of tree-shaking, but workerd within wrangler in dev mode does not tree-shake, that is why the cloudflare-integration-tests change it, but the e2e tests keep the nodejs_als, just to probe how far we can go with als support.

@JPeer264 JPeer264 self-assigned this Jul 31, 2026
@JPeer264
JPeer264 force-pushed the jp/prepare-nodejs-compat branch from 081be9d to cdebab6 Compare July 31, 2026 08:16
@JPeer264
JPeer264 marked this pull request as ready for review July 31, 2026 08:17
@JPeer264
JPeer264 requested a review from a team as a code owner July 31, 2026 08:17
@JPeer264
JPeer264 requested review from isaacs, mydea and nicohrubec and removed request for a team July 31, 2026 08:17
@JPeer264
JPeer264 force-pushed the jp/prepare-nodejs-compat branch from cdebab6 to 1a9f3d5 Compare July 31, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants