feat(cloudflare)!: Make the nodejs_compat entrypoint the default - #22900
Open
JPeer264 wants to merge 1 commit into
Open
feat(cloudflare)!: Make the nodejs_compat entrypoint the default#22900JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
JPeer264
force-pushed
the
jp/node-compat-cloudflare
branch
from
July 31, 2026 08:14
7397a23 to
6397b2e
Compare
JPeer264
force-pushed
the
jp/node-compat-cloudflare
branch
from
July 31, 2026 08:16
6397b2e to
8631715
Compare
JPeer264
marked this pull request as ready for review
July 31, 2026 08:25
JPeer264
requested review from
andreiborza,
isaacs and
nicohrubec
and removed request for
a team
July 31, 2026 08:25
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+13
to
+23
| import { vercelAiIntegration, type VercelAiOptions } from '@sentry/server-utils'; | ||
|
|
||
| const _vercelAIIntegration = ((options: VercelAiOptions = {}) => { | ||
| return { | ||
| name: INTEGRATION_NAME, | ||
| const inner = vercelAiIntegration(options); | ||
|
|
||
| return extendIntegration(inner, { | ||
| options, | ||
| setup(client) { | ||
| addVercelAiProcessors(client); | ||
| }, | ||
| }; | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: Importing vercelAIIntegration from the main entrypoint will cause a startup crash in Cloudflare Workers environments that do not have the nodejs_compat flag enabled.
Severity: HIGH
Suggested Fix
Revert the change that exports vercelAIIntegration from the main entrypoint (packages/cloudflare/src/index.ts). This integration and its Node.js-specific dependencies should be isolated in a separate entrypoint, such as the previously used @sentry/cloudflare/nodejs_compat, to prevent breaking users on runtimes without Node.js compatibility.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/cloudflare/src/integrations/tracing/vercelai.ts#L13-L23
Potential issue: The `vercelAIIntegration` is now exported from the main
`@sentry/cloudflare` package entrypoint. This integration depends on
`@sentry/server-utils`, which imports the Node.js-specific module
`node:diagnostics_channel` at the top level. Consequently, any user attempting to import
`vercelAIIntegration` in a Cloudflare Worker environment without the `nodejs_compat`
compatibility flag will experience a startup failure. The worker will fail to load
because it cannot resolve the `node:` module, which is a known constraint for certain
runtimes like Shopify Oxygen. This change violates an explicit architectural rule
designed to keep the main package entrypoint free of Node.js dependencies.
Also affects:
packages/cloudflare/src/index.ts:132
Did we get this right? 👍 / 👎 to inform future reviews.
JPeer264
changed the title
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/node-compat-cloudflare
branch
from
July 31, 2026 08:32
8631715 to
dcac51d
Compare
JPeer264
force-pushed
the
jp/node-compat-cloudflare
branch
from
July 31, 2026 10:19
dcac51d to
0a6bcec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the capabilities of the
/nodejs_compatentrypoint to the default entrypoint and removes the entrypoint entirely.On top I removed all
alsspecific tests, as they're not relevant anymore.