Skip to content

feat(core)!: Use rpc span op for MCP and tRPC - #22914

Draft
msonnb wants to merge 1 commit into
developfrom
ms/js-3105-rpc-op
Draft

feat(core)!: Use rpc span op for MCP and tRPC#22914
msonnb wants to merge 1 commit into
developfrom
ms/js-3105-rpc-op

Conversation

@msonnb

@msonnb msonnb commented Jul 31, 2026

Copy link
Copy Markdown
Member

MCP and tRPC are both JSON-RPC but each emitted its own op string. This migrates them onto the single cross-protocol rpc op from conventions.

MCP notification direction lived only in the op string, now relocated to the span origin.

Part of #22446

@linear-code

linear-code Bot commented Jul 31, 2026

Copy link
Copy Markdown

JS-3105

@msonnb

msonnb commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.82 kB - -
@sentry/browser - with treeshaking flags 28.02 kB - -
@sentry/browser (incl. Tracing) 47.08 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.09 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.82 kB - -
@sentry/browser (incl. Tracing, Replay) 86.39 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.83 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.11 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103.76 kB - -
@sentry/browser (incl. Feedback) 47.14 kB - -
@sentry/browser (incl. sendFeedback) 34.66 kB - -
@sentry/browser (incl. FeedbackAsync) 39.77 kB - -
@sentry/browser (incl. Metrics) 30.89 kB - -
@sentry/browser (incl. Logs) 31.12 kB - -
@sentry/browser (incl. Metrics & Logs) 31.8 kB - -
@sentry/react 31.61 kB - -
@sentry/react (incl. Tracing) 49.33 kB - -
@sentry/vue 34.74 kB - -
@sentry/vue (incl. Tracing) 49.05 kB - -
@sentry/svelte 29.86 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 47.45 kB - -
CDN Bundle (incl. Logs, Metrics) 33.42 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 48.83 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.78 kB - -
CDN Bundle (incl. Tracing, Replay) 85.08 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.38 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 90.85 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.16 kB - -
CDN Bundle - uncompressed 95.11 kB - -
CDN Bundle (incl. Tracing) - uncompressed 142.34 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.82 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 146.32 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.58 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 261.6 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 265.56 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 275.3 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 279.26 kB - -
@sentry/nextjs (client) 51.92 kB - -
@sentry/sveltekit (client) 47.51 kB - -
@sentry/core/server 79.7 kB +0.09% +70 B 🔺
@sentry/core/browser 51.7 kB - -
@sentry/node 121.41 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B - -
@sentry/node - without tracing 84.91 kB +0.01% +1 B 🔺
@sentry/aws-serverless 93.19 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 198.35 kB - -
@sentry/cloudflare (withSentry) 487.75 kB - -

View base workflow run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 31b7614. Configure here.

Comment thread packages/core/src/integrations/mcp-server/attributes.ts

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove MCP ops. Our MCP prebuilt dashboards (like this one) depend on the MCP ops. You're right, they'Re RPC calls under the hood but I think MCP warrants its own span ops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants