feat(core)!: Enable data collection by default (based on spec) - #22917
Draft
s1gr1d wants to merge 6 commits into
Draft
feat(core)!: Enable data collection by default (based on spec)#22917s1gr1d wants to merge 6 commits into
s1gr1d wants to merge 6 commits into
Conversation
s1gr1d
requested review from
andreiborza,
chargome,
isaacs,
logaretm and
msonnb
and removed request for
a team
July 31, 2026 12:28
s1gr1d
marked this pull request as draft
July 31, 2026 12:28
Contributor
size-limit report 📦
|
s1gr1d
commented
Jul 31, 2026
Member
Author
There was a problem hiding this comment.
We now collect 5 lines instead of 7. Based on spec: https://develop.sentry.dev/sdk/foundations/client/data-collection/#datacollection-options
# Conflicts: # packages/browser/test/client.test.ts # packages/browser/test/integrations/httpclient.test.ts # packages/core/test/lib/integrations/supabase.test.ts # packages/core/test/lib/logs/internal.test.ts # packages/core/test/lib/metrics/internal.test.ts # packages/core/test/lib/tracing/spans/captureSpan.test.ts # packages/core/test/lib/tracing/spans/envelope.test.ts # packages/core/test/lib/utils/data-collection/resolveDataCollectionOptions.test.ts # packages/core/test/lib/utils/request.test.ts # packages/deno/test/deno-serve.test.ts
Member
Author
|
@BugBot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f91785. Configure here.
| createEsmAndCjsTests(__dirname, 'server.mjs', 'instrument-with-datacollection.mjs', (createRunner, test) => { | ||
| test('applies request data attributes when using dataCollection config', async () => { | ||
| createEsmAndCjsTests(__dirname, 'server.mjs', 'instrument.mjs', (createRunner, test) => { | ||
| test('applies request data attributes by default', async () => { |
There was a problem hiding this comment.
Default path not actually tested
Medium Severity
The renamed test claims request data is applied by default, but it still runs instrument.mjs, which sets sendDefaultPii: true. That exercises the legacy bridge, not the new neither-option-set defaults, and duplicates the suite above it.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3f91785. Configure here.
s1gr1d
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First merge this PR (is merged): #22913
Enable the
dataCollectionspecification defaults when neitherdataCollectionnor the legacysendDefaultPiioption is configured.Tests and development test applications now rely on the new defaults instead of redundantly opting into
userInfoand related data.closes #22707