test(e2e): Merge tanstackstart orchestrion app into main test app - #22922
Open
chargome wants to merge 1 commit into
Open
test(e2e): Merge tanstackstart orchestrion app into main test app#22922chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
`sentryTanstackStart()` wires the orchestrion bundler plugin automatically since #22902, so a dedicated app no longer proves anything the main app doesn't. Fold the DB driver routes and tests into `tanstackstart-react`, which now exercises the built-in path. Drop the standalone app's `add-instrumentation.mjs` entry-prepending: it existed because that app started without `--import`, and `tanstackstart-react` already boots via `node --import ./.output/server/instrument.server.mjs`. Keeping it would test a second boot mechanism unrelated to orchestrion. Gate the Docker setup on the proxy variant. The DB tests carry the same `usesManagedTunnelRoute` skip as the other suites, so the five tunnel-route variants would otherwise boot MySQL and Redis only to skip the tests needing them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #22902
Now that build-time instrumentation is the default, a dedicated
tanstackstart-react-orchestrionapp no longer proves anything the main app doesn't — so its DB driver routes and tests are folded intotanstackstart-react.