Skip to content

test(e2e): Add missing @sentry/core dep to nextjs-16-userfeedback #22988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 1 commit into from
Aug 4, 2026
+1 −0
Merged

test(e2e): Add missing @sentry/core dep to nextjs-16-userfeedback #22988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"test:assert": "pnpm test:prod"
},
"dependencies": {
"@sentry/core": "file:../../packed/sentry-core-packed.tgz",

@sentry sentry Bot Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/core package is listed as a runtime dependency but is only used for a type-only import in a test file. It should be a devDependency.
Severity: LOW

Suggested Fix

In package.json, move the @sentry/core entry from the dependencies object to the devDependencies object. This correctly reflects that the package is only needed for development and type-checking, not for the runtime execution of the application.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/package.json#L14

Potential issue: The `@sentry/core` package is incorrectly listed in `dependencies`. It
is only used for a type-only import (`import type { FeedbackEvent } ...`) within the
test file `tests/feedback.test.ts`. Since TypeScript strips type-only imports during
compilation, this package is not required for the application to run. This leads to
incorrect package configuration and potential bundle bloat. For consistency, it should
be moved to `devDependencies`, similar to how other test applications in this repository
handle type-only test dependencies.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/nextjs": "file:../../packed/sentry-nextjs-packed.tgz",
"@types/node": "^20",
"@types/react": "^19",
Expand Down
Loading