Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,8 @@ Sentry.init({
- `getTraceContextForScope` was removed. Scope-to-trace-context resolution now goes through the shared core implementation.
- `OpenTelemetryServerRuntimeOptions` was removed.
- The `@opentelemetry/core` peer dependency was removed; its APIs are now vendored internally.
- OpenTelemetry resources are no longer collected, and `contexts.otel.resource` was dropped from events.
- `getSentryResource` was removed.
- OpenTelemetry resources are no longer collected, and `contexts.otel.resource` was dropped from events. As a result, the `OTEL_SERVICE_NAME` and `OTEL_RESOURCE_ATTRIBUTES` environment variables are no longer read by the SDK.

### `@sentry/core` span attributes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
culture: expect.any(Object),
device: expect.any(Object),
os: expect.any(Object),
otel: expect.any(Object),
runtime: expect.any(Object),
trace: {
data: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
culture: expect.any(Object),
device: expect.any(Object),
os: expect.any(Object),
otel: expect.any(Object),
runtime: expect.any(Object),
trace: {
data: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
culture: expect.any(Object),
device: expect.any(Object),
os: expect.any(Object),
otel: expect.any(Object),
runtime: expect.any(Object),
trace: {
data: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
culture: expect.any(Object),
device: expect.any(Object),
os: expect.any(Object),
otel: expect.any(Object),
runtime: expect.any(Object),
trace: {
data: {
Expand Down
17 changes: 1 addition & 16 deletions packages/node/src/sdk/initOtel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type { NodeClient } from './client';
import {
applyOtelSpanData,
backfillStreamedSpanDataFromOtel,
getSentryResource,
SentryPropagator,
SentryTracerProvider,
} from '@sentry/opentelemetry';
Expand Down Expand Up @@ -123,7 +122,7 @@ function getPreloadMethods(integrationNames?: string[]): ((() => void) & { id: s

/** Just exported for tests. */
export function setupOtel(client: NodeClient): SentryTracerProvider | undefined {
const provider = new SentryTracerProvider({ resource: getSentryResource('node') });
const provider = new SentryTracerProvider();

if (!registerGlobalTracerProvider(provider)) {
DEBUG_BUILD &&
Expand All @@ -143,19 +142,5 @@ export function setupOtel(client: NodeClient): SentryTracerProvider | undefined
client.on('preprocessSpan', backfillStreamedSpanDataFromOtel);
}

client.on('preprocessEvent', event => {
if (event.type !== 'transaction') {
return;
}

event.contexts = {
...event.contexts,
otel: {
resource: provider.resource?.attributes,
...event.contexts?.otel,
},
};
});

return provider;
}
11 changes: 0 additions & 11 deletions packages/node/test/integration/transactions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3', timestamp: 123456 },
]);

expect(transaction.contexts?.otel).toEqual({
resource: {
'service.name': 'node',
'service.namespace': 'sentry',
'service.version': expect.any(String),
'telemetry.sdk.language': 'nodejs',
'telemetry.sdk.name': 'opentelemetry',
'telemetry.sdk.version': expect.any(String),
},
});

expect(transaction.contexts?.trace).toEqual({
data: {
'sentry.op': 'test op',
Expand Down
2 changes: 0 additions & 2 deletions packages/opentelemetry/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ export { applyOtelSpanData } from './applyOtelSpanData';
export { backfillStreamedSpanDataFromOtel } from './utils/backfillStreamedSpanData';
export { SentryTracerProvider } from './tracerProvider';

export { getSentryResource } from './resource';

export { type AsyncLocalStorageLookup } from './asyncLocalStorageContextManager';

export { setOpenTelemetryContextAsyncContextStrategy } from './asyncContextStrategy';
101 changes: 0 additions & 101 deletions packages/opentelemetry/src/resource.ts

This file was deleted.

7 changes: 0 additions & 7 deletions packages/opentelemetry/src/tracerProvider.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
import type { Tracer, TracerOptions, TracerProvider } from '@opentelemetry/api';
import type { SpanAttributes } from '@sentry/core';
import { SentryTracer } from './tracer';

/**
* A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
*/
export class SentryTracerProvider implements TracerProvider {
public readonly resource?: { attributes: SpanAttributes };

private readonly _tracers = new Map<string, SentryTracer>();

public constructor(options: { resource?: { attributes: SpanAttributes } } = {}) {
this.resource = options.resource;
}

/** @inheritdoc */
public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
const key = JSON.stringify([name, version, options]);
Expand Down
3 changes: 1 addition & 2 deletions packages/opentelemetry/test/helpers/initOtel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { diag, DiagLogLevel, propagation, trace } from '@opentelemetry/api';
import { debug, getClient } from '@sentry/core';
import { DEBUG_BUILD } from '../../src/debug-build';
import { SentryPropagator } from '../../src/propagator';
import { getSentryResource } from '../../src/resource';
import { setupEventContextTrace } from '../../src/setupEventContextTrace';
import type { TestClient } from './TestClient';
import { SentryTracerProvider } from '../../src/tracerProvider';
Expand Down Expand Up @@ -38,7 +37,7 @@ export function initOtel(): void {

setupEventContextTrace(client);

const provider = new SentryTracerProvider({ resource: getSentryResource('node') });
const provider = new SentryTracerProvider();

trace.setGlobalTracerProvider(provider);
propagation.setGlobalPropagator(new SentryPropagator());
Expand Down
131 changes: 0 additions & 131 deletions packages/opentelemetry/test/resource.test.ts

This file was deleted.

3 changes: 1 addition & 2 deletions packages/vercel-edge/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
stackParserFromStackParserOptions,
} from '@sentry/core';
import {
getSentryResource,
SentryPropagator,
SentryTracerProvider,
setOpenTelemetryContextAsyncContextStrategy,
Expand Down Expand Up @@ -114,7 +113,7 @@ export function setupOtel(client: VercelEdgeClient): void {
setupOpenTelemetryLogger();
}

const provider = new SentryTracerProvider({ resource: getSentryResource('edge') });
const provider = new SentryTracerProvider();

trace.setGlobalTracerProvider(provider);
propagation.setGlobalPropagator(new SentryPropagator());
Expand Down
Loading