fix(browser): Respect dataCollection.httpHeaders.request in httpContextIntegration - #23025
Draft
chargome wants to merge 1 commit into
Draft
fix(browser): Respect dataCollection.httpHeaders.request in httpContextIntegration#23025chargome wants to merge 1 commit into
dataCollection.httpHeaders.request in httpContextIntegration#23025chargome wants to merge 1 commit into
Conversation
…ntextIntegration`
`httpContextIntegration` attached `Referer` and `User-Agent` without looking at
`dataCollection`, so `httpHeaders: { request: false }` worked on the server but did
nothing in the browser. Both hooks now filter through `httpHeaders.request`.
Filtering goes by header name rather than by what this integration collects, because
`browserTracingIntegration` puts the same two headers on transaction events before this
hook runs. Headers the user sets themselves are left alone, matching the spec and the
server.
Fixes #21272
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 976507c. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpContextIntegrationattachedRefererandUser-Agentwithout looking atdataCollection, sohttpHeaders: { request: false }worked on the server but did nothing in the browser. Both hooks now filter throughhttpHeaders.request.Headers the user sets themselves are left alone, matching the spec and the server.
Note the URL stays unfiltered:
url.fullignoresurlQueryParamson both platforms, so?token=…still gets sent. Pre-existing and untouched here, but probably worth its own issue.closes #21272