Conversation
Member
Author
|
bugbot run |
chargome
added this pull request to stack #24884
September 30, 2026 12:52
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
September 30, 2026 13:08
6639e08 to
e9f6e49
Compare
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
September 30, 2026 13:41
e9f6e49 to
29218a8
Compare
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
3 times, most recently
from
September 30, 2026 14:43
c7e625f to
b48cc8b
Compare
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
September 30, 2026 15:01
b48cc8b to
39eb61f
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
September 30, 2026 15:16
39eb61f to
7130dc2
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
October 1, 2026 08:02
7130dc2 to
975f10a
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
October 1, 2026 08:12
975f10a to
be24564
Compare
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
October 1, 2026 08:21
be24564 to
dc72542
Compare
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
2 times, most recently
from
October 1, 2026 08:46
af75881 to
c1d1c18
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
October 1, 2026 08:57
c1d1c18 to
b88a5b5
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b88a5b5. Configure here.
chargome
marked this pull request as ready for review
October 1, 2026 09:13
chargome
requested review from
JPeer264,
isaacs,
nicohrubec and
s1gr1d
and removed request for
a team
October 1, 2026 09:13
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
2 times, most recently
from
October 1, 2026 14:08
ee24cbc to
818658f
Compare
Base automatically changed from
charlygomez/js-3767-complete-remix-3-server-error-handling
to
develop
October 1, 2026 15:09
Remix 3 has no bundler, so the build time plugin the other SDKs use has nothing to attach to. The asset server compiles each module on request through a loader chain with Node's `load` hook shape, and that is the only compile time hook the browser pipeline has. This adds a loader there that applies orchestrion's transform, and patches `run` in `@remix-run/ui` so component render errors are captured with no application code. `@sentry/server-utils` gains a `load-hook` entry for callers with a file path and its source and no bundler in between. It is compiled into that package's build like the webpack loader, because the `@apm-js-collab` packages are bundled devDependencies and not resolvable on user installs. This keeps `@sentry/remix` free of the transformer as a dependency. The transform imports the browser `diagnostics_channel` shim by public URL, percent encoded per segment the way the asset server encodes rewritten imports, and the URL is listed in `scripts.external`. Two spellings of that URL are two modules to a browser, so a mismatch would load two shims with two subscriber registries and no instrumentation. The shim is now an explicit rollup entry: nothing in the module graph uses its default export, so a non entry module would have it tree shaken away, which the injected import needs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3772-run-the-orchestrion-transform-on-browser-modules
branch
from
October 1, 2026 15:09
818658f to
0a8d1a7
Compare
JPeer264
approved these changes
Oct 2, 2026
| declare global { | ||
| // `var`, because only a `var` here becomes a property of `globalThis`. | ||
| // oxlint-disable-next-line no-var | ||
| var __SENTRY_REMIX_DC_REGISTRY__: Map<string, BrowserTracingChannel> | undefined; |
Member
There was a problem hiding this comment.
q/l: You think it would make sense to add this to our GLOBAL_OBJ instead?
Member
Author
There was a problem hiding this comment.
Not really as this only affects remix 🤔
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remix 3 has no bundler, so the build time plugin the other SDKs use has nothing to attach to. The asset server compiles each module on request through a loader chain, and that is the only compile time hook the browser has. This adds a loader there that applies orchestrion's transform, and patches
runin@remix-run/uiso component render errors are captured with no application code.@sentry/server-utilsgains aload-hookentry for callers with a file path and its source and no bundler in between. It is bundled like the webpack loader, so@sentry/remixdoes not need the transformer as a dependency.The transform imports the browser
diagnostics_channelshim by public URL, encoded the way the asset server encodes imports and listed inscripts.external. A mismatched URL would load two shims and no instrumentation. The shim is now an explicit rollup entry, because nothing in the module graph uses its default export and rollup dropped it.Fixes #24677