test(e2e): Avoid rate limits when polling Sentry in send-to-sentry tests - #24957
Merged
Merged
Conversation
Co-Authored-By: Jan Peer Stöcklmair <jan.peer@sentry.io>
JPeer264
marked this pull request as ready for review
October 1, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The send-to-sentry E2E tests often fail with
429 Too Many Requests("Limit is 40 requests in 1 seconds"). Sentry rate limits GET requests per token owner, and every endpoint used here shares the default bucket. So all E2E jobs across all PRs share one 40 req/s budget.Most of the load came from
sentry trace view --json. The--jsonflag makes the CLI fetch details for every span, one request each (15 at a time), on top of a project lookup and the trace request. Every 5s poll turned into dozens of requests.fetchTracenow calls the trace endpoint directly throughsentry api, which is one request per poll. The tests only read fields that the raw trace response already includes (event_id,parent_span_id,event_type,op,description,children,errors,occurrences).All the polling helpers now also treat a 429 as "not there yet" and keep polling until the existing timeout, instead of failing on the first rate-limited response.
via Jan Peer Stöcklmair.
--
View Junior Session [Sentry]