Skip to content

fix(v10/nitro): Capture errors only through the Nitro error hook - #24963

Merged
nicohrubec merged 1 commit into
v10from
feat/v10-nitro-error-hook-capture
Oct 2, 2026
Merged

nicohrubec merged 1 commit into
v10from
feat/v10-nitro-error-hook-capture

Conversation

@nicohrubec

Copy link
Copy Markdown
Member

Backport of: #24952

Differences to the original PR

  • The 400-error regression test waits for the flush endpoint's transaction instead of a streamed span, matching v10's default trace lifecycle.
  • The standard error test checks the hook mechanism on the original Error instead of the HTTPError wrapper, matching v10's mechanism assignment within linked errors.

Fixes #24939

Backport of: #24952

Co-Authored-By: OpenAI Codex <codex@openai.com>
@nicohrubec
nicohrubec marked this pull request as ready for review October 2, 2026 07:19
@nicohrubec
nicohrubec requested a review from a team as a code owner October 2, 2026 07:19
@nicohrubec
nicohrubec requested review from JPeer264, chargome and s1gr1d and removed request for a team October 2, 2026 07:19
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.23 kB added added
@sentry/browser - with treeshaking flags 26.66 kB added added
@sentry/browser (incl. Tracing) 47.12 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 48.91 kB added added
@sentry/browser (incl. Tracing, Profiling) 51.89 kB added added
@sentry/browser (incl. Tracing, Replay) 86.4 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.06 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.13 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.76 kB added added
@sentry/browser (incl. Feedback) 45.39 kB added added
@sentry/browser (incl. sendFeedback) 33.03 kB added added
@sentry/browser (incl. FeedbackAsync) 38.16 kB added added
@sentry/browser (incl. Metrics) 29.31 kB added added
@sentry/browser (incl. Logs) 29.54 kB added added
@sentry/browser (incl. Metrics & Logs) 30.23 kB added added
@sentry/react 30.02 kB added added
@sentry/react (incl. Tracing) 49.44 kB added added
@sentry/vue 33.66 kB added added
@sentry/vue (incl. Tracing) 49.13 kB added added
@sentry/svelte 28.25 kB added added
CDN Bundle 30.58 kB added added
CDN Bundle (incl. Tracing) 49.07 kB added added
CDN Bundle (incl. Logs, Metrics) 32.16 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.39 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.5 kB added added
CDN Bundle (incl. Tracing, Replay) 86.67 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.93 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.48 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.75 kB added added
CDN Bundle - uncompressed 90.96 kB added added
CDN Bundle (incl. Tracing) - uncompressed 147.96 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.67 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.94 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 220.63 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.39 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.35 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.09 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.04 kB added added
@sentry/nextjs (client) 51.96 kB added added
@sentry/sveltekit (client) 47.57 kB added added
@sentry/core/server 81.14 kB added added
@sentry/core/browser 67.27 kB added added
@sentry/node-core 63.87 kB added added
@sentry/node 126.57 kB added added
@sentry/node (incl. diagnostics channel injection) 170.72 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 51.98 kB added added
@sentry/node - without tracing 75.63 kB added added
@sentry/aws-serverless 84.81 kB added added
@sentry/cloudflare (withSentry) - minified 204.66 kB added added
@sentry/cloudflare (withSentry) 504.61 kB added added

@nicohrubec
nicohrubec merged commit e8dfc58 into v10 Oct 2, 2026
41 checks passed
@nicohrubec
nicohrubec deleted the feat/v10-nitro-error-hook-capture branch October 2, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants