feat(remix): Warn when the Remix 3 instrumentation does not apply - #24968
Closed
chargome wants to merge 2 commits into
Conversation
chargome
added this pull request to stack #24884
October 2, 2026 08:22
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
force-pushed
the
charlygomez/js-3774-warn-when-remix-3-instrumentation-does-not-apply
branch
from
October 2, 2026 08:33
38365d9 to
ddd4b67
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3774-warn-when-remix-3-instrumentation-does-not-apply
branch
from
October 2, 2026 08:34
ddd4b67 to
a838f0a
Compare
Member
Author
|
bugbot run |
1 similar comment
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3774-warn-when-remix-3-instrumentation-does-not-apply
branch
from
October 2, 2026 08:36
a838f0a to
3a8517d
Compare
A module the runtime hook transformed is listed in `__SENTRY_ORCHESTRION__.runtime`. After `init()`, once the app's import graph has loaded, the integration checks that list for the Remix 3 server modules. An installed module that is missing is reported with its reason: imported before the hook was registered, or a version outside the range the transform matches. A hook that could not be registered at all names the Node version. The subscribers that patch a router, request listener or asset server no longer fail silently when the call has a shape they cannot patch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The log stands in for the listener's default handler. Sandboxed so the SDK's console instrumentation does not report the error a second time. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3774-warn-when-remix-3-instrumentation-does-not-apply
branch
from
October 2, 2026 08:46
3a8517d to
73abd6b
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 73abd6b. Configure here.
Member
Author
|
Closing: we ship the alpha without the startup warning. The consoleSandbox fix moves to #24943. |
1 of 3 tasks
An error occurred while trying to automatically change base from
charlygomez/js-3773-add-source-map-upload-for-remix-3
to
develop
October 2, 2026 11:36
chargome
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 2, 2026
## DESCRIBE YOUR PR Adds a setup page for the Remix 3 support that `@sentry/remix` ships under its `/v3` subpaths: the `--import` entry that replaces `remix/node-tsx`, the two `init()` calls, the `allowPackages` and `define` additions to the asset server, the source map upload command, and the warning the SDK prints when the instrumentation did not apply. Marked alpha, API can change. The Remix guide's "not yet supported" alert now points to it. Do not merge before the SDK alpha is published. SDK PRs: getsentry/sentry-javascript#24943, getsentry/sentry-javascript#24968. Refs getsentry/sentry-javascript#24687. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning if our instrumentation does not grip. It's on by default, not behind
debug.Only the router module is checked:
remixdepends on all@remix-run/*packages, so the others look installed whether or not the app uses them.The e2e test starts the app with
--import remix/node-tsxinstead of the Sentry entry and checks for the warning.Fixes #24679