Skip to content

ref(core): Use idle span finish reason constant from conventions - #24970

Merged
nicohrubec merged 1 commit into
developfrom
feat/idle-span-finish-reason-conventions
Oct 2, 2026
Merged

nicohrubec merged 1 commit into
developfrom
feat/idle-span-finish-reason-conventions

Conversation

@nicohrubec

Copy link
Copy Markdown
Member

Uses SENTRY_IDLE_SPAN_FINISH_REASON from @sentry/conventions/attributes in idle-span handling and existing constant-based tests. Deprecates the existing core constant while preserving its public export and the identical sentry.idle_span_finish_reason key.

Part of #24961 / JS-3868.

@nicohrubec
nicohrubec marked this pull request as ready for review October 2, 2026 09:38
@nicohrubec
nicohrubec requested a review from a team as a code owner October 2, 2026 09:38
@nicohrubec
nicohrubec requested review from Lms24, logaretm and msonnb and removed request for a team October 2, 2026 09:38
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.52 kB - -
@sentry/browser - with treeshaking flags 27.68 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.57 kB - -
@sentry/browser (incl. Tracing) 51.45 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 51.46 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.46 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay) 91.04 kB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.03 kB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 95.74 kB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 108.71 kB - -
@sentry/browser (incl. Feedback) 47.04 kB - -
@sentry/browser (incl. sendFeedback) 34.57 kB - -
@sentry/browser (incl. FeedbackAsync) 39.68 kB - -
@sentry/browser (incl. Metrics) 30.54 kB - -
@sentry/browser (incl. Logs) 30.82 kB - -
@sentry/browser (incl. Metrics & Logs) 31.48 kB - -
@sentry/react 31.36 kB - -
@sentry/react (incl. Tracing) 53.8 kB -0.04% -19 B 🔽
@sentry/vue 37.51 kB - -
@sentry/vue (incl. Tracing) 54.33 kB -0.04% -21 B 🔽
@sentry/svelte 29.55 kB - -
@sentry/remix (Remix 3 client bundle) 55.77 kB +0.01% +3 B 🔺
CDN Bundle 31.22 kB - -
CDN Bundle (incl. Tracing) 51.98 kB -0.01% -4 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.46 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.91 kB -0.05% -23 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 74.2 kB - -
CDN Bundle (incl. Tracing, Replay) 89.56 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.53 kB -0.01% -9 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 95.72 kB -0.02% -11 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.71 kB -0.03% -23 B 🔽
CDN Bundle - uncompressed 92.14 kB - -
CDN Bundle (incl. Tracing) - uncompressed 154.49 kB -0.03% -36 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.71 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 160.45 kB -0.03% -36 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 228.28 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 274.22 kB -0.02% -36 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 280.16 kB -0.02% -36 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.93 kB -0.02% -36 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.86 kB -0.02% -36 B 🔽
@sentry/nextjs (client) 56.32 kB -0.02% -8 B 🔽
@sentry/sveltekit (client) 51.87 kB -0.01% -4 B 🔽
@sentry/core/server 40.59 kB - -
@sentry/core/browser 13.63 kB +0.02% +2 B 🔺
@sentry/node 144.68 kB +0.01% +11 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.2 kB - -
@sentry/node - without tracing 93.24 kB +0.02% +10 B 🔺
@sentry/node - without channel injection 122.95 kB +0.01% +8 B 🔺
@sentry/aws-serverless 101.51 kB +0.01% +5 B 🔺
@sentry/cloudflare (withSentry) - minified 208.62 kB - -
@sentry/cloudflare (withSentry) 518.21 kB - -

View base workflow run

@nicohrubec
nicohrubec enabled auto-merge (squash) October 2, 2026 09:41
@nicohrubec
nicohrubec merged commit 8198603 into develop Oct 2, 2026
354 of 355 checks passed
@nicohrubec
nicohrubec deleted the feat/idle-span-finish-reason-conventions branch October 2, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants