Conversation
Cloudflare documents Clef as compatible with the Jev API, but only Jev
calls had tracing tests. The integration test mock returns the documented
Clef response, which has no `{ state, result }` wrapper, so it also covers
that branch of the evaluate response handling. The E2E test calls the real
model to verify the response shape that the binding returns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
marked this pull request as ready for review
October 5, 2026 06:24
JPeer264
requested review from
andreiborza and
mydea
and removed request for
a team
October 5, 2026 06:24
nicohrubec
approved these changes
Oct 5, 2026
| status: 'ok', | ||
| is_segment: false, | ||
| attributes: { | ||
| 'sentry.origin': { value: 'auto.ai.cloudflare.workers_ai', type: 'string' }, |
Member
There was a problem hiding this comment.
l: sentry.origin / sentry.op / sentry.is_localhost should all be in conventions so we could use the consts from there directly
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
enabled auto-merge (squash)
October 5, 2026 09:34
Trace `@cf/cloudflare/clef` calls as `evaluate` spans. Since evaluation models are detected by model ID instead of the `state` + `questions` input shape, Clef calls became `chat` spans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
changed the title
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Oct 6, 2026
andreiborza
added a commit
that referenced
this pull request
Oct 6, 2026
…s constant (#25070) ## What Bugbot now flags attribute names and span ops written as strings (e.g. `'sentry.origin'`) when `@sentry/conventions` has a constant for them. The rule applies to SDK source and to tests. ## Why Reviewers often have to point this out by hand, for example in #25027 (comment). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
nicohrubec
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare documents Clef (
@cf/cloudflare/clef) as a drop-in for Jev with the samestate+questionsrequest shape. Released versions trace Clef asevaluateonly because of that shape. #25033 now finds evaluation models by model ID, so without this change Clef calls would becomechatspans. This adds the Clef model ID to the evaluate detection, plus a Clef integration test and a real-Worker E2E test.The integration mock returns the documented Clef response, which has no
{ state, result }wrapper (the Jev binding response has one). That makes it cover the unwrapped branch of the evaluate response handling, which the Jev test does not reach. The E2E test calls the real model, so it is the one that confirms what the binding actually returns. The docs do not give amodelvalue for the response, so it only asserts that it containsclef.Fixes #25011
🤖 Generated with Claude Code