Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/nuxt/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { SentryNuxtModuleOptions } from './common/types';
import { setupNitroServer } from './vite/nitroServer';
import { setupOrchestrion } from './vite/orchestrion';
import { setupSourceMaps } from './vite/sourceMaps';
import { addOTelCommonJSImportAlias, findDefaultSdkInitFile, resolveServerApi } from './vite/utils';
import { findDefaultSdkInitFile, resolveServerApi } from './vite/utils';

export type ModuleOptions = SentryNuxtModuleOptions;
type NuxtPageSubset = { file?: string; path: string };
Expand Down Expand Up @@ -97,8 +97,6 @@ export default defineNuxtModule<ModuleOptions>({
setupSourceMaps(moduleOptions, nuxt, addVitePlugin);
}

addOTelCommonJSImportAlias(nuxt, serverApi === 'nitro3');
Comment thread
cursor[bot] marked this conversation as resolved.

let pagesData: NuxtPageSubset[] = [];

nuxt.hooks.hook('pages:extend', pages => {
Expand Down
24 changes: 0 additions & 24 deletions packages/nuxt/src/vite/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,27 +224,3 @@ export function toResolvablePath(source: string): { path: string; wasFileUrl: bo
return undefined;
}
}

/**
* Sets up alias to work around OpenTelemetry's incomplete ESM imports.
* https://github.com/getsentry/sentry-javascript/issues/15204
*
* OpenTelemetry's @opentelemetry/resources package has incomplete imports missing
* the .js file extensions (like execAsync for machine-id detection). This causes module resolution
* errors in certain Nuxt configurations, particularly when local Nuxt modules in Nuxt 4 are present.
*
* @see https://nuxt.com/docs/guide/concepts/esm#aliasing-libraries
*/
export function addOTelCommonJSImportAlias(nuxt: Nuxt, isNitroV3 = false): void {
if (!nuxt.options.dev || isNitroV3) {
return;
}

if (!nuxt.options.alias) {
nuxt.options.alias = {};
}

if (!nuxt.options.alias['@opentelemetry/resources']) {
nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js';
}
}
70 changes: 0 additions & 70 deletions packages/nuxt/test/vite/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import * as fs from 'fs';
import * as path from 'path';
import { afterEach, describe, expect, it, vi } from 'vitest';
import {
addOTelCommonJSImportAlias,
constructFunctionReExport,
constructWrappedFunctionExportQuery,
extractFunctionReexportQueryParameters,
Expand Down Expand Up @@ -428,72 +427,3 @@ export { foo_sentryWrapped as foo };
expect(result).toBe('');
});
});

describe('addOTelCommonJSImportAlias', () => {
it('adds alias for @opentelemetry/resources when options.alias does not exist', () => {
const nuxtMock: Nuxt = {
options: { dev: true },
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toEqual({
'@opentelemetry/resources': '@opentelemetry/resources/build/src/index.js',
});
});

it('adds alias for @opentelemetry/resources when options.alias already exists', () => {
const nuxtMock: Nuxt = {
options: {
dev: true,
alias: {
'existing-alias': 'some-path',
},
},
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toEqual({
'existing-alias': 'some-path',
'@opentelemetry/resources': '@opentelemetry/resources/build/src/index.js',
});
});

it('does not override existing alias for @opentelemetry/resources', () => {
const nuxtMock: Nuxt = {
options: {
dev: true,
alias: {
'@opentelemetry/resources': 'some-other-path',
},
},
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toEqual({
'@opentelemetry/resources': 'some-other-path',
});
});

it('does not add alias when not development mode', () => {
const nuxtMock: Nuxt = {
options: {},
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toBeUndefined();
});

it('does not add alias when in Nitro v3+ (Rolldown incompatibility)', () => {
const nuxtMock: Nuxt = {
options: { dev: true },
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock, true);

expect(nuxtMock.options.alias).toBeUndefined();
});
});
Loading