Skip to content

test(node): Use default streaming in scope and span suites #25222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 1 commit into from
Oct 9, 2026
Merged

test(node): Use default streaming in scope and span suites #25222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dev-packages/bun-integration-tests/node-suites/excludes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ const NO_HTTP_SERVER_SPANS = [
'suites/tracing/httpIntegration-streamed/test.ts',
'suites/tracing/httpIntegration/test.ts',
'suites/tracing/httpServerSpans-unrouted/test.ts',
'suites/tracing/ignoreSpans-streamed/**',
'suites/tracing/ignoreSpans/**',
'suites/tracing/meta-tags-twp-errors/test.ts',
'suites/tracing/meta-tags/test.ts',
'suites/tracing/requestData/test.ts',
'suites/tracing/sample-rand-propagation/test.ts',
'suites/tracing/sample-rate-propagation/**',
'suites/tracing/sampling-static/test.ts',
'suites/tracing/sampling-streamed/test.ts',
'suites/tracing/sampling/test.ts',
'suites/tracing/traceid-recycling-with-spans/test.ts',
'suites/tracing/traceid-recycling/test.ts',
];
Expand Down Expand Up @@ -170,7 +170,7 @@ const FETCH_INTEGRATION_DIFFERS = [
'suites/tracing/http-client-spans/fetch-basic/test.ts',
'suites/tracing/http-client-spans/fetch-error/test.ts',
'suites/tracing/http-client-spans/fetch-strip-query/test.ts',
'suites/tracing/ignoreSpans-streamed/continued-trace-http-client/test.ts',
'suites/tracing/ignoreSpans/continued-trace-http-client/test.ts',
'suites/tracing/requests/fetch-breadcrumbs/test.ts',
'suites/tracing/requests/fetch-sampled-no-active-span/test.ts',
];
Expand All @@ -194,11 +194,11 @@ const NO_EXPRESS_INSTRUMENTATION = [
'suites/sessions/crashed-session-aggregate/test.ts',
'suites/sessions/errored-session-aggregate/test.ts',
'suites/tracing/httpIntegration-streamed/test.ts',
'suites/tracing/ignoreSpans-streamed/attributes/test.ts',
'suites/tracing/ignoreSpans-streamed/children/test.ts',
'suites/tracing/ignoreSpans-streamed/continued-trace-child/test.ts',
'suites/tracing/ignoreSpans-streamed/segments/test.ts',
'suites/tracing/sampling-streamed/test.ts',
'suites/tracing/ignoreSpans/attributes/test.ts',
'suites/tracing/ignoreSpans/children/test.ts',
'suites/tracing/ignoreSpans/continued-trace-child/test.ts',
'suites/tracing/ignoreSpans/segments/test.ts',
'suites/tracing/sampling/test.ts',
'suites/tracing/traceid-recycling-with-spans/test.ts',
];

Expand Down
6 changes: 3 additions & 3 deletions dev-packages/deno-integration-tests/node-suites/excludes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ const NO_FETCH_INSTRUMENTATION = [
'suites/tracing/http-client-spans/fetch-forward-request-hook/test.ts',
'suites/tracing/http-client-spans/fetch-headers-to-span-attributes/test.ts',
'suites/tracing/http-client-spans/fetch-strip-query/test.ts',
'suites/tracing/ignoreSpans-streamed/continued-trace-child/test.ts',
'suites/tracing/ignoreSpans-streamed/continued-trace-http-client/test.ts',
'suites/tracing/ignoreSpans-streamed/continued-trace-segment/test.ts',
'suites/tracing/ignoreSpans/continued-trace-child/test.ts',
'suites/tracing/ignoreSpans/continued-trace-http-client/test.ts',
'suites/tracing/ignoreSpans/continued-trace-segment/test.ts',
'suites/tracing/no-parent-span-client-report/test.ts',
'suites/tracing/requests/fetch-breadcrumbs/test.ts',
'suites/tracing/requests/fetch-no-trace-propagation/test.ts',
Expand Down
1 change: 0 additions & 1 deletion ...tests/suites/context-streamed/scenario.ts → ...egration-tests/suites/context/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { loggingTransport } from '@sentry-internal/node-integration-tests';
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
tracesSampleRate: 1.0,
traceLifecycle: 'stream',
transport: loggingTransport,
});

Expand Down
1 change: 0 additions & 1 deletion ...ntext-streamed/scope-contexts/scenario.ts → ...suites/context/scope-contexts/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { loggingTransport } from '@sentry-internal/node-integration-tests';
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
tracesSampleRate: 1.0,
traceLifecycle: 'stream',
transport: loggingTransport,
});

Expand Down
0 ...s/context-streamed/scope-contexts/test.ts → ...sts/suites/context/scope-contexts/test.ts
View file
Open in desktop
File renamed without changes.
0 ...ion-tests/suites/context-streamed/test.ts → ...-integration-tests/suites/context/test.ts
View file
Open in desktop
File renamed without changes.
0 ...c-api/beforeSendSpan-streamed/scenario.ts → ...tes/public-api/beforeSendSpan/scenario.ts
View file
Open in desktop
File renamed without changes.
0 ...ublic-api/beforeSendSpan-streamed/test.ts → .../suites/public-api/beforeSendSpan/test.ts
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/public-api/scopes/initialScopes/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/public-api/scopes/isolationScope/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
Expand Down
1 change: 0 additions & 1 deletion ...eSpans-streamed/attributes/instrument.mjs → ...ing/ignoreSpans/attributes/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Sentry.init({
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: [{ attributes: { 'http.request.method': 'POST' } }],
clientReportFlushInterval: 1_000,
});
0 ...gnoreSpans-streamed/attributes/server.mjs → ...tracing/ignoreSpans/attributes/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...g/ignoreSpans-streamed/attributes/test.ts → ...es/tracing/ignoreSpans/attributes/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';

describe('filtering segment spans by attribute with ignoreSpans (streaming)', () => {
describe('filtering segment spans by attribute with ignoreSpans', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion ...oreSpans-streamed/children/instrument.mjs → ...acing/ignoreSpans/children/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Sentry.init({
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: ['expressInit', /custom-to-drop/, { op: 'ignored-op' }],
clientReportFlushInterval: 1_000,
});
0 .../ignoreSpans-streamed/children/server.mjs → ...s/tracing/ignoreSpans/children/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ing/ignoreSpans-streamed/children/test.ts → ...ites/tracing/ignoreSpans/children/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { SENTRY_OP } from '@sentry/conventions/attributes';
import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';

describe('filtering child spans with ignoreSpans (streaming)', () => {
describe('filtering child spans with ignoreSpans', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion ...amed/continued-trace-child/instrument.mjs → ...pans/continued-trace-child/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
tracesSampleRate: 0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: ['ignoredMiddleware'],
tracePropagationTargets: [process.env.SERVER_URL],
clientReportFlushInterval: 1_000,
Expand Down
0 ...streamed/continued-trace-child/server.mjs → ...oreSpans/continued-trace-child/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ns-streamed/continued-trace-child/test.ts → ...ignoreSpans/continued-trace-child/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';
import { SENTRY_OP } from '@sentry/conventions/attributes';

describe('ignoring a child of a continued server segment (streaming)', () => {
describe('ignoring a child of a continued server segment', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion ...ontinued-trace-http-client/instrument.mjs → ...ontinued-trace-http-client/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
tracesSampleRate: 0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: [{ attributes: { 'url.path': '/outgoing' } }],
tracePropagationTargets: [process.env.SERVER_URL],
clientReportFlushInterval: 1_000,
Expand Down
0 ...ed/continued-trace-http-client/server.mjs → ...ns/continued-trace-http-client/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...eamed/continued-trace-http-client/test.ts → ...Spans/continued-trace-http-client/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';
import { SENTRY_OP } from '@sentry/conventions/attributes';

describe('ignoring an HTTP client child of a continued server segment (streaming)', () => {
describe('ignoring an HTTP client child of a continued server segment', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion ...ed/continued-trace-segment/instrument.mjs → ...ns/continued-trace-segment/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
tracesSampleRate: 0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: [{ op: 'http.server' }],
tracePropagationTargets: [process.env.SERVER_URL],
});
0 ...reamed/continued-trace-segment/server.mjs → ...eSpans/continued-trace-segment/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...-streamed/continued-trace-segment/test.ts → ...noreSpans/continued-trace-segment/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { afterAll, describe, expect } from 'vitest';
import { RUNTIME } from '../../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';

describe('ignoring a continued server segment (streaming)', () => {
describe('ignoring a continued server segment', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion ...oreSpans-streamed/segments/instrument.mjs → ...acing/ignoreSpans/segments/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Sentry.init({
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
traceLifecycle: 'stream',
ignoreSpans: [{ attributes: { 'url.path': '/health' } }],
clientReportFlushInterval: 1_000,
});
0 .../ignoreSpans-streamed/segments/server.mjs → ...s/tracing/ignoreSpans/segments/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ing/ignoreSpans-streamed/segments/test.ts → ...ites/tracing/ignoreSpans/segments/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../../utils/runner';

describe('filtering segment spans with ignoreSpans (streaming)', () => {
describe('filtering segment spans with ignoreSpans', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
1 change: 0 additions & 1 deletion .../tracing/sampling-streamed/instrument.mjs → ...ts/suites/tracing/sampling/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ Sentry.init({
return inheritOrSampleWith(1);
},
transport: loggingTransport,
traceLifecycle: 'stream',
clientReportFlushInterval: 1_000,
});
0 ...ites/tracing/sampling-streamed/server.mjs → ...-tests/suites/tracing/sampling/server.mjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../suites/tracing/sampling-streamed/test.ts → ...ion-tests/suites/tracing/sampling/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('negative sampling (streaming)', () => {
describe('negative sampling', () => {
afterAll(() => {
cleanupChildProcesses();
});
Expand Down
Loading