Skip to content

feat(core): Support SuppressedError in LinkedErrors integration - #25246

Open
kunal649 wants to merge 1 commit into
getsentry:developfrom
kunal649:kunal/feat/support-suppressed-error
Open

kunal649 wants to merge 1 commit into
getsentry:developfrom
kunal649:kunal/feat/support-suppressed-error

Conversation

@kunal649

Copy link
Copy Markdown

SuppressedError is what JS throws when a cleanup (using / Symbol.dispose) fails while another error is already in flight. It keeps both errors, error (the new one) and suppressed (the original), and it has no cause. because of that, LinkedErrors never saw them. In Sentry I only got the generic wrapper message, "An error was suppressed during disposal".
Take a look , how it looks today (node SDK):

Screenshot 2026-10-11 195752

This change makes aggregateExceptionsFromError also follow error and suppressed, the same way it already follows cause and errors[], both errors now show up as chained exceptions. If a SuppressedError has another SuppressedError inside, it goes down the chain too.

And one thing I'm not sure about: I did not set is_exception_group on the wrapper. From #10850 i understand that flag makes sentry ignore that entry for grouping and titles, and that was a problem for cause errors. But the wrapper here has a meaningless message, so maybe it should be a group. (happy to change it if you prefer.)

I added tests for both errors, nested SuppressedErrors, non-Error values, and an error that only has an error property (it must not be treated as a SuppressedError).

Fixes #8441

@github-actions github-actions Bot added the external PR from an external contributor label Oct 11, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1834d47. Configure here.

});

expect(event.exception?.values).toHaveLength(1);
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feat lacks integration coverage

Medium Severity

This feat only adds unit tests around applyAggregateErrorsToEvent with a fake SuppressedError. The testing conventions require at least one integration or E2E test for feat PRs. An end-to-end captureException case with a native SuppressedError, matching the existing AggregateError suites, is missing.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 1834d47. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle SuppressedError

1 participant