Correct route and dynamic param extraction for Expo Router (#6157)#6197
Open
alwx wants to merge 2 commits into
Open
Correct route and dynamic param extraction for Expo Router (#6157)#6197alwx wants to merge 2 commits into
alwx wants to merge 2 commits into
Conversation
Contributor
Author
|
@cursor review this please |
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 31c8c4f. Configure here.
antonis
reviewed
May 21, 2026
| */ | ||
| registerNavigationContainer: (navigationContainerRef: unknown) => void; | ||
| /** | ||
| * Internal API: allow another integration (for example, Expo Router integration) to |
Contributor
There was a problem hiding this comment.
I think an @internal annotation should make the api checker happy 🤞
Suggested change
| * Internal API: allow another integration (for example, Expo Router integration) to | |
| * @internal API: allow another integration (for example, Expo Router integration) to |
antonis
reviewed
May 21, 2026
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Other than the API change issue LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes #6157
The idea is simple: when Expo Router is active, we can get the route from Expo Router's own state rather than from getCurrentRoute().name. That allows for this information about route and params to be more precise and detailed compared to the filename-based approach of React Navigation.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps