Skip to content

fix: Fix double counting of Faraday spans when using net_http_persistent adapter #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertjlooby wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Fix double counting of Faraday spans when using net_http_persistent adapter #3017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1ad459
Add dev dependency on faraday-net_http_persistent
Jul 10, 2026
d5dd432
Add spec showing double counting of Faraday spans when using net_http…
Jul 10, 2026
db42db9
Fix double counting of Faraday spans when using net_http_persistent a…
Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry-ruby/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ gem "benchmark-memory"
gem "yard"
gem "webrick"
gem "faraday"
gem "faraday-net_http_persistent"

@solnic solnic Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not introduce this dep and use a test adapter that would reproduce the issue instead?

gem "excon"
gem "webmock"

Expand Down
10 changes: 9 additions & 1 deletion sentry-ruby/gemfiles/ruby-2.7_rack-2_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion sentry-ruby/gemfiles/ruby-2.7_rack-3.1_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion sentry-ruby/gemfiles/ruby-2.7_rack-3_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions sentry-ruby/gemfiles/ruby-3.0_rack-2_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions sentry-ruby/gemfiles/ruby-3.0_rack-3.1_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions sentry-ruby/gemfiles/ruby-3.0_rack-3_redis-4.gemfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading