Skip to content

fix!(sentry-tracing): Make EventMapping non-exhaustive#1097

Merged
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/non-exhaustive-event-mapping
Apr 27, 2026
Merged

fix!(sentry-tracing): Make EventMapping non-exhaustive#1097
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/non-exhaustive-event-mapping

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

Make EventMapping non-exhaustive. This prevents the log feature from introducing a breaking change by adding a variant to the enum, while also allowing us to add variants in the future without breaking the public API.

Closes #1090
Closes RUST-203

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 27, 2026

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/non-exhaustive-event-mapping branch from 2acaf15 to d867ad9 Compare April 27, 2026 16:05
Make `EventMapping` non-exhaustive. This prevents the log feature from introducing a breaking change by adding a variant to the enum, while also allowing us to add variants in the future without breaking the public API.

Closes #1090
Closes [RUST-203](https://linear.app/getsentry/issue/RUST-203/sentry-tracing-add-non-exhaustive-to-eventmapping)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/non-exhaustive-event-mapping branch from d867ad9 to 57d4bdb Compare April 27, 2026 16:10
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 27, 2026 16:11
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner April 27, 2026 16:11
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) April 27, 2026 16:11
@szokeasaurusrex szokeasaurusrex merged commit 63b33d9 into master Apr 27, 2026
24 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/non-exhaustive-event-mapping branch April 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentry-tracing: add #[non_exhaustive] to EventMapping

2 participants