Skip to content

chore(tracing): Enforce strict trace continuation#1218

Open
szokeasaurusrex wants to merge 3 commits into
szokeasaurusrex/org-id-baggage-parsingfrom
strict-trace-continuation
Open

chore(tracing): Enforce strict trace continuation#1218
szokeasaurusrex wants to merge 3 commits into
szokeasaurusrex/org-id-baggage-parsingfrom
strict-trace-continuation

Conversation

@szokeasaurusrex

@szokeasaurusrex szokeasaurusrex commented Jul 1, 2026

Copy link
Copy Markdown
Member

Compare incoming and SDK organization IDs before transaction sampling so incompatible incoming traces start a new trace instead of inheriting the parent trace and sampling decision.

Also keep org ID parsing behind the client feature and document the behavior as a trace-continuation safety improvement.

Fixes #1201
Fixes RUST-253

@szokeasaurusrex szokeasaurusrex changed the title strict trace continuation fix(tracing): Enforce strict trace continuation Jul 1, 2026
@linear-code

linear-code Bot commented Jul 1, 2026

Copy link
Copy Markdown

RUST-253

@szokeasaurusrex szokeasaurusrex force-pushed the strict-trace-continuation branch from 3030840 to f11e463 Compare July 1, 2026 16:55

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new logic is here, the rest is config-gating to avoid dead code warnings and tests

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 1, 2026 16:57
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner July 1, 2026 16:57
@szokeasaurusrex szokeasaurusrex changed the title fix(tracing): Enforce strict trace continuation chore(tracing): Enforce strict trace continuation Jul 2, 2026
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/org-id-baggage-parsing branch from afb3de5 to 8515ce7 Compare July 7, 2026 11:05
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner July 7, 2026 11:05
@szokeasaurusrex szokeasaurusrex force-pushed the strict-trace-continuation branch from f11e463 to dccf418 Compare July 7, 2026 11:05
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/org-id-baggage-parsing branch from 8515ce7 to 8524289 Compare July 8, 2026 13:56
@szokeasaurusrex szokeasaurusrex force-pushed the strict-trace-continuation branch from dccf418 to 78f09ee Compare July 8, 2026 13:56
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/org-id-baggage-parsing branch from 8524289 to becf1b2 Compare July 8, 2026 14:04
@szokeasaurusrex szokeasaurusrex force-pushed the strict-trace-continuation branch from 78f09ee to f2d28da Compare July 8, 2026 14:04
szokeasaurusrex and others added 2 commits July 9, 2026 15:17
Compare incoming and SDK organization IDs before transaction sampling so incompatible incoming traces start a new trace instead of inheriting the parent trace and sampling decision.

Also keep org ID parsing behind the client feature and document the behavior as a trace-continuation safety improvement.

Fixes [#1201](#1201)
Fixes [RUST-253](https://linear.app/getsentry/issue/RUST-253)
@szokeasaurusrex szokeasaurusrex force-pushed the strict-trace-continuation branch from f2d28da to 802f1a1 Compare July 9, 2026 13:17
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/org-id-baggage-parsing branch from becf1b2 to 7af8474 Compare July 9, 2026 13:17
@szokeasaurusrex szokeasaurusrex marked this pull request as draft July 9, 2026 14:37
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 10, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce strict trace continuation when starting transactions

1 participant