Skip to content

fix(cli): narrow metric alert dataset before mapping - #1599

Merged
BYK merged 1 commit into
mainfrom
fix/cli-alerts-dataset-lint
Oct 22, 2026
Merged

BYK merged 1 commit into
mainfrom
fix/cli-alerts-dataset-lint

Conversation

@betegon

@betegon betegon commented Oct 22, 2026

Copy link
Copy Markdown
Member

Fix the typescript/no-base-to-string error in alerts.ts that blocks repository and CLI lint, including #1598. Reuse the existing pickDetectorString helper so supported dataset strings and native monitor edit round-trips stay unchanged.

Validated with 189 focused alert tests, workspace typechecks, repository/CLI lint, and CLI policy checks. The full suite still hits existing CLI failures in the macOS install-script fixture and missing Xcode actool; all non-CLI suites pass.

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Oct 22, 2026 3:30pm UTC

Request Review

@BYK
BYK marked this pull request as ready for review October 22, 2026 15:37
@github-actions github-actions Bot added the risk: low PR risk score: low label Oct 22, 2026
@BYK
BYK merged commit f5004b2 into main Oct 22, 2026
27 checks passed
@BYK
BYK deleted the fix/cli-alerts-dataset-lint branch October 22, 2026 15:49

This branch was previously deployed

1 inactive deployment
Preview — 8f32961b Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants