Repository navigation
chore(cli): Upgrade @sentry/api to 0.399.0 - #1643
Merged
Merged
Conversation
0.399.0 adds named types for enum-valued query parameters (getsentry/sentry-api-schema#108), such as ListOrganizationTraceItemAttributesQueryDataset, so callers can stop deriving them with NonNullable<...["query"]>. Two schema changes since 0.356.0 affect existing tests: - Organization Sentry App components now include a required installationUuid (getsentry/sentry#127591). The issue-link fixture gains it, since the CLI validates the response against the schema. - The replay index now accepts every replay response field, including replay_type (getsentry/sentry#128518). The tests that expected replay_type to be rejected now use a field outside the schema. Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Oct 23, 2026
BYK
enabled auto-merge (squash)
October 23, 2026 22:21
sentry-junior
Bot
changed the title
sentry-junior
Bot
changed the title
BYK
added a commit
that referenced
this pull request
Oct 23, 2026
Upgrades the CLI's `@sentry/api` dependency from `^0.399.0` (#1643) to `^0.400.0`, the first release with getsentry/sentry#128639. That change withholds `info_ids` and `warning_ids` from the public replay `field` enum. The 0.400.0 types differ from 0.399.0 only in that enum, on the replay index and details endpoints. The lockfile change only covers `@sentry/api`. `pnpm-workspace.yaml` moves the `minimumReleaseAgeExclude` entry to 0.400.0, because it was published today. Since #1617, replay explore builds its fields from the schema. New assertions in `test/lib/replay-search.test.ts` check that: - `replay_type` and `ota_updates.channel` are supported. - `info_ids` and `warning_ids` are neither supported fields nor requestable roots. Verification: typecheck and lint pass, and a frozen-lockfile install passes. The replay, explore, and issue-app-links tests pass (149 tests). I didn't rerun the full suite, because the schema change is limited to that enum. <!-- junior-request-attribution:start --> via **BYK**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC010884QHLG%3A1792754298.933159 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC010884QHLG%3A1792754298.933159) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC010884QHLG%3A1792754298.933159/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: BYK <burak.kaya@sentry.io>
sentry-junior Bot
added a commit
that referenced
this pull request
Oct 23, 2026
Switch TraceItemAttributeDataset and TraceItemAttributeValueType to the
ListOrganizationTraceItemAttributesQuery{Dataset,AttributeType} exports
added in @sentry/api (#1643) instead of deriving them
from the query shape.
Co-Authored-By: BYK <burak.kaya@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the CLI's
@sentry/apidependency from^0.356.0to^0.399.0, the release that includes getsentry/sentry-api-schema#108. That release exports a named type for every enum-valued query parameter, such asListOrganizationTraceItemAttributesQueryDataset, so callers no longer need to derive them withNonNullable<…["query"]>. #1559 will switch its trace-item attribute types to these once this lands.The lockfile change only covers
@sentry/api.pnpm-workspace.yamlmoves theminimumReleaseAgeExcludeentry to the new version, because 0.399.0 was published today.Two schema changes between 0.356.0 and 0.399.0 broke existing tests. Both changes match Sentry's current behavior, so the tests were updated rather than the code:
installationUuid(feat(sentry-apps): Return installation UUID with org components sentry#127591). The CLI validates this response against the schema, so theissue-app-linkstest fixture now includes the field; without it, all 37 issue-link tests failed. The org endpoint always passesinstallation_uuidsto the serializer, so live responses always include the field. Self-hosted servers older than that change will fail this validation.replay_type, because the field list comes fromReplayDetailsResponse(fix(replays): Reject unknown fields on replay details endpoints sentry#128518). The two tests that expectedreplay_typeto be rejected now check a field that isn't in the schema,device.model_id.Verification: typecheck and lint pass. CLI tests: 11,295 passed and 6 failed. The 6 failures are permission tests that also fail on a clean
mainin my sandbox (completions, code-scanner, file-changes, telemetry, upgrade).The follow-up bump to 0.400.0 is #1645.
via BYK.
--
View Junior Session [Sentry]