Repository navigation
feat(chat): knowledge parity with MCP — file passages, entities, facts, status - #89
Merged
Merged
Conversation
leorfer23
force-pushed
the
feat/chat-knowledge-parity
branch
from
October 14, 2026 19:11
ab0a17f to
5e120c3
Compare
…s, status The in-app assistant's knowledge_search only read the distilled notes tree, so anything learned from uploaded Files (PDFs, docs, sheets) was invisible to it while the MCP connector could cite it. knowledge_search now also returns cited corpus passages, and the chat gets knowledge_entity, knowledge_facts and knowledge_status backed by the same corpus/graph helpers the REST routes use, with the same per-member source visibility plus an explicit workspace-membership check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leorfer23
force-pushed
the
feat/chat-knowledge-parity
branch
from
October 14, 2026 19:21
5e120c3 to
445ad8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The in-app assistant's
knowledge_searchonly read the distilled notes tree. Anything learned from uploaded Files (PDFs, docs, sheets) — the corpus the MCP connector cites — was invisible to it. MCP and the REST API could answer "what does the onboarding procedure say?"; the in-app chat couldn't.What
knowledge_search(chat) now also returns citedpassagesfrom the corpus (searchCorpus), alongside the existing note summaries. Akindfilter still means notes only.knowledge_entity,knowledge_facts,knowledge_status. They call the same helpers the REST routes use (listVisibleEntities,visibleEntity,visibleSources,store.listSources).getUserWorkspaceIds) since these bypass the route's member gate.knowledgetoolkit, progress labels (en/es), docs (teams/knowledge.mden/es) and skill (team/knowledge.md,team/workspace-assistant.md); skill bundle rebuilt.Tests
tests/unit/knowledge/chat-corpus-tools.test.ts: cited passages from an uploaded file, private-file isolation, entity + quoted facts, status lists only visible sources, refuses non-member / personal / knowledge-off.tests/unit/knowledge/agent-tools.test.ts: mock membership.tooling/scripts/ci-check-fast.shpasses locally (exit 0).Not in this PR
Full API parity for the chat (beyond knowledge) — e.g. MCP's
publish_artifact/update_artifact/whoami/list_workspacesvs chat'screate_artifact/edit_page, and admin/settings routes — to be inventoried separately.🤖 Generated with Claude Code