Conversation
Companion to getyourguide/public-partner-api: a booking request without bookable.price used to fail with a 500 and now returns 400 (errorCode 12). Description-only change; price was already listed as required. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to getyourguide/public-partner-api#2105.
POST /{version}/bookingswithoutdata.booking.bookable.priceused to fail with a 500 (NullPointerExceptionin the price check). It now returns a 400 (errorCode12,Booking price is required.) before any availability or pricing lookup.Changes:
spec/paths/bookings.yaml): spell out the requiredbookablefields (option_id,datetime,price,categories), the 400 for a missingprice, and that a presentpriceis then checked against the option's current price (errorCode308).No schema or type changes:
pricewas already listed underrequiredforbookable, so generated clients are unaffected. Description-only, same shape as #125.Checklist:
🤖 Generated with Claude Code