Skip to content

chat: fix LFM2/LFM2.5 ignoring json_schema#24377

Merged
pwilkin merged 1 commit into
ggml-org:masterfrom
tdakhran:tarek/fix/json-schema-grammar
Jun 10, 2026
Merged

chat: fix LFM2/LFM2.5 ignoring json_schema#24377
pwilkin merged 1 commit into
ggml-org:masterfrom
tdakhran:tarek/fix/json-schema-grammar

Conversation

@tdakhran

@tdakhran tdakhran commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Overview

The LFM2 specialized template handler only built a grammar for tool-calling, silently ignoring json_schema from response_format.

Additional information

Use

llama-server -hf LiquidAI/LFM2.5-1.2B-Instruct-GGUF:Q8_0

with the script below
request_schema.sh

Content before fix: The sum of 19 and 4 is 23.
Content after fix: { \"answer\" : 23, \"schema_guard\" : \"SCHEMA_ENFORCED\" }

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES, suggested changes similar to gemma4 and PR review

@tdakhran tdakhran requested a review from a team as a code owner June 9, 2026 19:47
The LFM2 specialized template handler only built a grammar for tool-calling,
silently ignoring json_schema from response_format.
@tdakhran tdakhran force-pushed the tarek/fix/json-schema-grammar branch from ff6c883 to a891311 Compare June 9, 2026 19:49
@tdakhran

Copy link
Copy Markdown
Contributor Author

@pwilkin could you please take a look?

@pwilkin pwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks proper.

@pwilkin pwilkin merged commit d2462f8 into ggml-org:master Jun 10, 2026
25 checks passed
@tdakhran tdakhran deleted the tarek/fix/json-schema-grammar branch June 10, 2026 12:48
@mtasic85

Copy link
Copy Markdown
Contributor

Great catch! This one was giving me hard time.

Jcfunk added a commit to Jcfunk/llama.cpp that referenced this pull request Jun 11, 2026
* upstream/HEAD: (329 commits)
  vendor : update LibreSSL to 4.3.2 (ggml-org#24397)
  Remove padding and multiple D2D copies for MTP (ggml-org#24086)
  chat: fix LFM2/LFM2.5 ignoring json_schema (ggml-org#24377)
  CUDA: Fix ssm_scan_f32 data-races (ggml-org#24360)
  ci : bump komac version (ggml-org#24396)
  speculative : fix "ngram-map-k4v" name in logging (ggml-org#24253)
  webui: implement pinned conversations support (ggml-org#21387)
  graph: Fix granite speech model inference by applying embedding scale when deepstack is not used (ggml-org#24357)
  ci : fix windows release (ggml-org#24369)
  ui: add opt-in run_javascript frontend tool (ggml-org#24244)
  mtmd: build_vit batching (ggml-org#24352)
  vulkan: reduce iq1 shared memory usage for mul_mm (ggml-org#24287)
  vulkan: add `v_dot2_f32_f16` support in matrix-matrix multiplication and Flash Attention (ggml-org#24123)
  ui: Fix excessive style recalculation on hover (ggml-org#24243)
  mtmd: refactor video subproc handling (ggml-org#24316)
  server: log prompts to directory (ggml-org#22031)
  ui: fix mobile chat form overflow and bust stale bundle cache (ggml-org#24158)
  ggml : add GGML_OP_COL2IM_1D (ggml-org#24206)
  server : do not clear slots without unified KV cache (ggml-org#24190)
  models : fix plamo2 attention_key/value_length regression (ggml-org#24317)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants