CUDA: extend K-type validation to V-types for flash attention#24403
Open
sanmai wants to merge 2 commits into
Open
CUDA: extend K-type validation to V-types for flash attention#24403sanmai wants to merge 2 commits into
sanmai wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extends the K-type validation to V-types in
ggml_cuda_get_best_fattn_kernel.Additional information
As with
GGML_CUDA_FA_ALL_QUANTS=ONall combinations are possible and unsupported combinations lead to crash instead of falling back to the CPU backend, say-ctk iq4_nl -ctv q8_0falls back to the CPU, but-ctk q8_0 -ctv iq4_nlleads to crash.Requirements