Skip to content

refactor: single scrollbar add and named slack in getHeadersWidth #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghiscoding merged 1 commit into from
Aug 10, 2026
Merged

refactor: single scrollbar add and named slack in getHeadersWidth #2717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/common/src/core/slickGrid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ import type { SlickDataView } from './slickDataview.js';
import { Draggable, MouseWheel, Resizable } from './slickInteractions.js';
import { applyHtmlToElement, runOptionalHtmlSanitizer } from './utils.js';

// slack added beyond the summed column widths so the header band always exceeds the
// body scroll range (header width is the header/body scroll-sync floor) and column
// drag-reorder has room past the last column
const HEADER_WIDTH_SLACK = 1000;
const RESIZE_AUTOSCROLL_MIN_INTERVAL_MS = 30;
const RESIZE_AUTOSCROLL_MAX_INTERVAL_MS = 600;
const RESIZE_AUTOSCROLL_ACCELERATE_INTERVAL = 5;
Expand Down Expand Up @@ -1264,16 +1268,14 @@ export class SlickGrid<TData = any, C extends Column<TData> = Column<TData>, O e
}

if (this.hasFrozenColumns()) {
this.headersWidthL = this.headersWidthL + 1000;
this.headersWidthL = this.headersWidthL + HEADER_WIDTH_SLACK;
this.headersWidthR = Math.max(this.headersWidthR, this.viewportW) + this.headersWidthL;
this.headersWidthR += this.scrollbarDimensions?.width || 0;
} else {
this.headersWidthL += this.scrollbarDimensions?.width || 0;
this.headersWidthL = Math.max(this.headersWidthL, this.viewportW) + 1000;
this.headersWidthL = Math.max(this.headersWidthL, this.viewportW) + HEADER_WIDTH_SLACK;
}

this.headersWidth = this.headersWidthL + this.headersWidthR;
return Math.max(this.headersWidth, this.viewportW) + 1000;
return Math.max(this.headersWidth, this.viewportW) + HEADER_WIDTH_SLACK;
}

/** Get the grid canvas width */
Expand Down
Loading