feat(s7commplus): complete subscription lifecycle - #891
Closed
gijzelaerr wants to merge 5 commits into
Closed
gijzelaerr wants to merge 5 commits into
gijzelaerr wants to merge 5 commits into
Conversation
…ifecycle # Conflicts: # s7commplus/async_client.py
This was referenced Sep 11, 2026
Owner
Author
|
This S7CommPlus work is now tracked in gijzelaerr/s7commplus#20. Pull requests cannot be transferred between repositories, so this PR is being closed in favor of the new-repository tracking issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gijzelaerr/s7commplus#7.
Completes the sync and async subscription lifecycle with typed catalog-backed notifications, bounded per-subscription queues, callbacks/iterators, finite-credit replenishment, mixed alarm/data routing, deletion cleanup, reconnect cleanup, and observable loss diagnostics. Raw payload bytes remain available alongside decoded values.
This is stacked on #886 for the symbolic tag catalog and includes the response-dispatch/integrity dependencies from #883 and #884.
Local verification:
uv run pre-commit run --all-filesuv run --offline pytest -q --tb=short(2123 passed, 82 skipped)uv build --offline --quiet