Repository navigation
fix(ci): run the DCO checker from the base branch - #8
Merged
Merged
Conversation
The DCO job checked out the PR head and ran check_dco.py from it, which failed for branches created before the script existed (PR #7) and let a PR edit the checker to pass. Check out the base commit instead and fetch the PR commits by ref. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Giovanny Rodriguez <giovanny.rodriguez@imagunet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DCO job checked out the PR head and ran
check_dco.pyfrom it. That has two problems:The job now checks out the base commit and fetches the PR commits via
refs/pull/N/head.🤖 Generated with Claude Code