Skip to content

fix: use model instead of name#73

Merged
ecarreras merged 1 commit into
masterfrom
fix-remove-view-use-model
Feb 26, 2026
Merged

fix: use model instead of name#73
ecarreras merged 1 commit into
masterfrom
fix-remove-view-use-model

Conversation

@ecarreras
Copy link
Copy Markdown
Member

This pull request makes a small but important fix to the query used in the change_column_type function in oopgrade/oopgrade.py. The change ensures that the query checks the correct column in the ir_model table.

  • Updated the SQL query in change_column_type to check the model column instead of the name column in ir_model, ensuring accurate existence checks for models.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the change_column_type function where the SQL query was checking the wrong column in the ir_model table. The function is used to alter column types in database tables, and before making changes, it needs to check if any views depend on the table being modified. When checking if a model exists in the ir_model table, the code was incorrectly querying the name column instead of the model column.

Changes:

  • Fixed SQL query in change_column_type to check the model column (not name) when verifying model existence in ir_model table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ecarreras ecarreras merged commit 8aea07d into master Feb 26, 2026
8 checks passed
@ecarreras ecarreras deleted the fix-remove-view-use-model branch February 26, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants