fix: use model instead of name#73
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the change_column_type function where the SQL query was checking the wrong column in the ir_model table. The function is used to alter column types in database tables, and before making changes, it needs to check if any views depend on the table being modified. When checking if a model exists in the ir_model table, the code was incorrectly querying the name column instead of the model column.
Changes:
- Fixed SQL query in
change_column_typeto check themodelcolumn (notname) when verifying model existence inir_modeltable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
polsala
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important fix to the query used in the
change_column_typefunction inoopgrade/oopgrade.py. The change ensures that the query checks the correct column in their_modeltable.change_column_typeto check themodelcolumn instead of thenamecolumn inir_model, ensuring accurate existence checks for models.