Skip to content

Impl - #1

Merged
MichaelMure merged 10 commits into
masterfrom
impl
Oct 9, 2026
Merged

MichaelMure merged 10 commits into
masterfrom
impl

Conversation

@MichaelMure

@MichaelMure MichaelMure commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5 Tier: plus

Do not merge yet: broken commondir still blocks otherwise valid protected and file-only loads.

Summary

Implements Git configuration reads and edits, including scoped loads, conditional includes, typed getters, and locked file updates.

  • Adds EnvError so callers can identify malformed environment variables.
  • Clarifies API behavior and adds tests for error messages.
  • Replaces the reverse global-file loop with slices.Backward without changing file selection.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["Discover or caller-supplied Env"] --> B["Load scopes or files"]
  B --> C["Follow matching includes"]
  C --> D["Immutable Config"]
  E["Parse bytes"] --> F["Editable File"]
  F --> D
  F --> G["Edit and check entries"]
  H["UpdateFile or UpdateScope"] --> I["Lock and read target"]
  I --> G
  G --> J["Write lock and rename"]
Loading

Reviews (9) · Last reviewed commit: "improve an error case" · Reviewed by Greptile

Comment thread update.go Outdated
Comment thread glob.go Outdated
Comment thread glob.go
Comment thread load.go
Comment thread update.go
Comment thread env.go Outdated
Comment thread env.go
Comment thread edit.go
Comment thread load.go Outdated
Comment thread load.go Outdated
Comment thread load.go
@MichaelMure
MichaelMure requested a balanced review from Copilot October 9, 2026 14:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MichaelMure
MichaelMure merged commit 7cc2d8f into master Oct 9, 2026
4 checks passed
@MichaelMure
MichaelMure deleted the impl branch October 10, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants