feat(i18n, layout): add dock orientation options and translations - #8
Merged
gitgusilva merged 1 commit intoJul 30, 2026
Merged
Conversation
Introduced new localization strings for "Dock to bottom" and "Dock to right" in English, Spanish, and Brazilian Portuguese. Updated layout service to manage details orientation, allowing users to toggle between bottom and right docking for the details panel in the History view.
Collaborator
Author
|
gitgusilva
added
enhancement
gitgusilva
approved these changes
Jul 30, 2026
gitgusilva
left a comment
gitgusilva
left a comment
Owner
There was a problem hiding this comment.
Approved. Pulled the branch locally, built the UI (vue-tsc -b && vite build clean) and ran it in dev: docking to the bottom, the resizer on the new axis and the persisted orientation all behave as expected. Reusing the existing Resizer with vertical/axis: 'y' and mirroring persistedSize in persistedString (with validation of the stored value) is the right fit for the codebase, and the default stays right, so nothing changes until the button is clicked.
Two notes, neither blocking. I will take care of them in a follow-up commit on main:
- The panel container draws its border with
border-neutral-200 dark:border-transparent. Since ef4fcfc every surface takes its border from theborder-linetoken, so this one stops following the active theme.border-t border-line/border-l border-linekeeps it consistent. - The dock button markup is repeated in the multi-select header and in
#tab-actions, worth extracting if that block grows.
Thanks for the contribution.
gitgusilva
added a commit
that referenced
this pull request
Jul 30, 2026
The dock-orientation change (#8) painted the panel's border with border-neutral-200 dark:border-transparent, the pattern ef4fcfc removed everywhere else. It leaves that edge outside the theme: a fixed grey under every light theme, and no border at all under every dark one, whatever the theme asked for. border-line is the token the other 258 borders in the app already use.
gitgusilva
added a commit
that referenced
this pull request
Jul 30, 2026
GitBox moves from MIT to the GNU Lesser General Public License, version 3 or later. Modifying GitBox itself now carries the obligation to publish those modifications, which MIT never asked for, while linking the project into another program stays permitted. The LGPL is written as a set of additional permissions on top of the GPL and carries no terms of its own, so both texts have to travel with the project: LICENSE holds the LGPL, GPL-3.0.txt the GPL it refers to. The file it is named LICENSE so the links in README and CONTRIBUTING keep working and so GitHub still reports the licence; the second file is deliberately not named COPYING, which would make the repository look dual-licensed to the detectors. ui/electron/package.json gains the license field it never had. It is what electron-builder writes into the deb and rpm metadata, so packages shipped until now declared no licence at all. Releases up to v1.2.0 went out under MIT and stay available under it: that grant cannot be withdrawn, and nothing here tries to. The one outside contribution merged so far (#8) came in under MIT, which permits relicensing, so no consent is needed to carry it over.
gitgusilva
added a commit
that referenced
this pull request
Jul 31, 2026
The v1.3.0 entry was written from the last branch alone and left out the six commits that landed before it — including the docked history detail panel contributed in #8, which the pull request diff panel builds on, and the relicensing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced new localization strings for "Dock to bottom" and "Dock to right" in English, Spanish, and Brazilian Portuguese. Updated layout service to manage details orientation, allowing users to toggle between bottom and right docking for the details panel in the History view.