C#: Property- and Indexer call targets for partial overrides.#21881
Draft
michaelnebel wants to merge 5 commits into
Draft
C#: Property- and Indexer call targets for partial overrides.#21881michaelnebel wants to merge 5 commits into
michaelnebel wants to merge 5 commits into
Conversation
… apply to only a getter or a setter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that call targets for properties and indexers are missing, when only the getter or setter is overridden.
Assume we have
For the example below, we extract an access to the property
ValuefromDerivedClass1. However, only the getter is overridden, which means that the setter being called is the one fromBaseClass.Furthermore, the function pointer calls are removed from the set of calls where we are interested in reporting missing call targets (as the class of function pointer calls explicitly overrides the
getTargetpredicate withnone()).