Repository navigation
JavaScript: Remove unused SEMMLE_TYPESCRIPT_MEMORY_THRESHOLD - #22887
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed06a454-bbdc-4586-8a7c-a7bc93c59413
paldepind
force-pushed
the
js/remove-envvar
branch
from
October 26, 2026 06:29
2c58dbe to
dc78645
Compare
paldepind
marked this pull request as ready for review
October 26, 2026 06:44
SEMMLE_TYPESCRIPT_MEMORY_THRESHOLD
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cleanup removes unused wiring and corrects documentation without changing heap sizing or parser behavior.
No open issues 🎉
What changed in this PR
Removes obsolete TypeScript memory-threshold wiring from the JavaScript extractor and updates documentation to match existing heap limits.
Changes:
- Stops setting the unused
SEMMLE_TYPESCRIPT_MEMORY_THRESHOLDenvironment variable. - Documents the 2000 MB default plus 400 MB reserve and removes outdated compiler-restart claims.
| File | Description |
|---|---|
javascript/extractor/src/com/semmle/ts/extractor/TypeScriptParser.java |
Removes unused environment wiring and corrects memory-setting documentation. |
Review effort: Max
asgerf
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b0062cf removed reloading the TypeScript server in the TypeScript extractor that was dead code since we stopped extracting types (I think).
Following that, this PR:
SEMMLE_TYPESCRIPT_MEMORY_THRESHOLDin the Java extractor-side as the env var is now unused. This is the last reference to that envvar.To see the value of the defaults:
setupParserWrapper()readsTYPESCRIPT_RAMwith a default of 2000 MB andTYPESCRIPT_RAM_RESERVEwith a default of 400 MB. Below the Node.js invocation sets--max_old_space_sizetomainMemoryMb + reserveMemoryMb: 2000 + 400 = 2400 MB by default.